854618 - [B2G] A Facebook contact's Home field title is always shown in English

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Description

[Chris Kreinbring [:CKreinbring]]

Attachment: Screenshot of Home field titles

Description:
On a Spanish language device, the Home field's title of a Facebook contact will be shown in English.  A user created contact will have the Home field's title shown in Spanish.  A user created contact linked to a Facebook contact will show one of each.

Repro Steps:
1) Updated to Unagi Build ID: 20130325070201
2) Select Settings, then Language, then change the language to Spanish.
3) Restart the device and select the Contacts app once the restart finishes.
4) Tap the settings icon (gear) in the upper right corner.
5) Tap the Facebook switch.
6) Enter a valid username and password and log in.
7) Select some contacts (or tap Marcar Todos) then tap Importar.
8) Once the importing finishes, select a contact that was just added.
9) Observe the title of the Home field.

Actual:
The Home field's title is shown in English (Home).

Expected:
The Home field's title in shown in Spanish (Hogar).

Environmental  Variables:
Kernel Date: Dec 5
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18_v1_0_1/rev/4931ec89ebbe
Gaia: 701b594c3e320030c538aa19f702764b29a6cc1c

Notes:
Repro frequency: 100%
Q Analysts Test Team Priority: Pri 3
See attached screenshot for more info.

Comment 1

[Guillermo López :willyaranda (probably SLOW response)]

Can you check if the gaia revision is on v1-train or v1.0.1? (I don't have access to a computer these days)

Comment 2

[Daniel Coloma:dcoloma]

(In reply to Guillermo López (:willyaranda) from comment #1)
> Can you check if the gaia revision is on v1-train or v1.0.1? (I don't have
> access to a computer these days)

it is happening in v1.0.1 and not only in Spanish but also in Portuguese...

Comment 3

[Jose Manuel Cantera]

Attachment: Pointer to GH PR #8942

We were not translating type labels for email, phone or address. The proposed patch translates the types (those which are not custom defined by the user).

Comment 4

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 732353 [details]
Pointer to GH PR #8942

Nice work!

Thanks.

Comment 5

[Jose Manuel Cantera]

https://github.com/mozilla-b2g/gaia/commit/85fff9a2566b3878b7b61cca523bf2da7b31e0ce

Comment 6

[John Ford [:jhford] CET/CEST Berlin Time]

Uplifted commit 85fff9a2566b3878b7b61cca523bf2da7b31e0ce as:
v1-train: aaa6da965314bd654339d6a9828f9c9627eb0e6c
v1.0.1: b4959a8e6132db0b458055bfb1b90db4d0c83079

Comment 7

[Chris Kreinbring [:CKreinbring]]

Fix verified on Unagi version 20130408075816 (1.0.1) and 20130408075751 (1.1).

The Spanish version now shows the Home label as Hogar for Facebook contacts.
The Portuguese version now shows the Home label as Residencial for Facebook contacts.