854786 - [Dialer]Accepting Incoming call when already in call is not hiding the accept/reject/ignore call option

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Dialer, defect)

Description

[Leo]

1. Title : Accepting second incoming call by holding existing call doesnt hide the options accept,reject,ignore call 
2. Precondition : Existing Ongoing call
3. Tester's Action :
	           1) Get another incoming call 
		   2) In OnCall screen, touch on exisiting call number. It will put the existing call on hold and automatically accept the new call
		  
4. Detailed Symptom (ENG.) : It is observed that even after accepting call by the above actions ,  ( accept ,reject ,ignore call )options are still shown .
5. Gaia Version : a78ebf426840b5ef08c0cc3e437ad30aba3e2528
6. Expected : OPtions should be hidden when the call is already accepted ( output should be same as when we accept the new call by choosing accept button)
7.Reproducibility: Y
1)Frequency Rate : 100%

Comment 1

[Etienne Segonzac (:etienne)]

Attachment: Pointer to github's PR

Comment 2

[Leo]

I think that URL is https://github.com/mozilla-b2g/gaia/pull/8827 ( You upload wrong URL )

Comment 3

[Leo]

I modify Expected result :

When touching on existing call number, cannot accept the new call.(no reaction in device)

Comment 4

[Germán Toro del Valle (:gtorodelvalle)]

Comment on attachment 729537 [details]
Pointer to github's PR

Simple and effective ;-) r+

Comment 5

[Etienne Segonzac (:etienne)]

Sadly the requirements changed under our feet in Comment 3, so a new patch will be needed.

Comment 6

[Leo]

Attachment: Pull request URL 8884

When selecting existing number, check call state.

If 'incoming' call state exist, cannot accept call

Comment 7

[Leo]

Attachment: Bug_854786 video

Comment 8

[Etienne Segonzac (:etienne)]

Comment on attachment 731052 [details]
Pull request URL 8884

No need to inspect all the calls, we can keep this strictly UI.

What we want is to ignore the clicks on the calls section [1] when we're displaying the call waiting UI.

So we can just add a condition in the |toggleCalls| function [2] that does an early return if |CallScreen.incomingContainer.classList.contains('displayed');|.

Thanks for taking this bug by the way!

[1] https://github.com/mozilla-b2g/gaia/blob/master/apps/communications/dialer/js/oncall.js#L52-53

[2] https://github.com/mozilla-b2g/gaia/blob/master/apps/communications/dialer/js/oncall.js#L573-575

Comment 9

[Leo]

Thank you for your advice!

I change source. Please review

Comment 10

[Etienne Segonzac (:etienne)]

Comment on attachment 731052 [details]
Pull request URL 8884

r=me with the lint issue fixed (extra space at the end of the line)

Comment 11

[Wayne Chang [:wchang]]

Bad user experience and unable to take second call, setting leo+

Comment 12

[Wayne Chang [:wchang]]

Sorry please disregard comment 11.

Corrected comment:
Triage on 4/2 - setting leo+ due to bad user experience and may cause confusion.

Comment 13

[[e-mail], [e-mail]]

Attachment: Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/9954

Pointer to Github pull-request

Comment 14

[[e-mail], [e-mail]]

Comment on attachment 753204 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/9954

Just keeping on the fixing process from comment 10.

Etienne,

Could you please help to review the pr again? Thank you.

Comment 15

[Germán Toro del Valle (:gtorodelvalle)]

Including Ayman as CC since he is currently checking the Call Waiting functionality ;-)

Comment 16

[Etienne Segonzac (:etienne)]

Comment on attachment 753204 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/9954

Commented on github, should be quick to address :)

Comment 17

[ayman maat :maat]

Hey guys

Just out of curiosity why are we allowing the end user to interact with the blue bar at the top of the screen when a second call is incoming before they have interacted with any of the other CTAs on the screen ('end call', 'pause call', ' ignore call')? This behavior does not make any sense and was never specified. Refer to wireframe pack HTML5_Dialer_Contacts_20120810_R2S1_V6.0 pages 28 to 32 for specification.

Comment 18

[ayman maat :maat]

Attachment: HTML5_Dialer_Contacts_20120810_R2S1_V6.0

Attached in relation to comment 17

Comment 19

[[e-mail], [e-mail]]

Comment on attachment 753204 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/9954

Etienne,
I agree with your suggestion. It's more clearly to distinguish 2 early return for 'toggleCalls()'.

Comment 20

[[e-mail], [e-mail]]

(In reply to ayman maat :maat from comment #17)
> Hey guys
> 
> Just out of curiosity why are we allowing the end user to interact with the
> blue bar at the top of the screen when a second call is incoming before they
> have interacted with any of the other CTAs on the screen ('end call', 'pause
> call', ' ignore call')? This behavior does not make any sense and was never
> specified. Refer to wireframe pack HTML5_Dialer_Contacts_20120810_R2S1_V6.0
> pages 28 to 32 for specification.

Hi Ayman,
For your question, we are fixing it in the issue.

Regarding to comment 0:
3. Tester's Action :
   1) Get another incoming call 
   2) In OnCall screen, touch on exisiting call number. It will put the existing call on hold and automatically accept the new call

(The exisiting call number should be equal to "on the blue bar at the top of screen".)

After the patch landed, It won't accept the second call on the blue bar at the top of screen while first call is active. Thanks for your point out:)

Comment 21

[Etienne Segonzac (:etienne)]

Comment on attachment 753204 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/9954

Thanks!

Comment 22

[[e-mail], [e-mail]]

Thanks for Etienne's reviewing effort. Since the pr landed, we can close the issue now.

master:   7878532edf5fe7b44d1889be6b736313b08cd47a
v1-train: f8cd3a5d6cf5a7789e4f6e635678842aeda42b31

Comment 23

[William Hsu [:whsu]]

Adding a related test case.
 - https://moztrap.mozilla.org/manage/case/8460/