854869 - [Performance] [CallLog DB] _generateGroupKey it's not working

Status: RESOLVED DUPLICATE of bug 848027

(Firefox OS Graveyard :: Gaia::Dialer, defect)

Description

[Borja Salguero [:borjasalguero]]

_generateGroupKey method, needed for grouping, only takes into account the date and number, but not the type of the call. This means that one missed-call and one out-going call will have the same ID, and that's why it's not working.

Comment 1

[Borja Salguero [:borjasalguero]]

Attachment: Pull Request

Due to Fernando is on Holidays, could you take a look? It's a small change but it's blocking my PR of call-log. Thanks!

Comment 2

[Etienne Segonzac (:etienne)]

Comment on attachment 729501 [details]
Pull Request

To be completely honest I thought this change was on purpose to simplify the call log :)

Anyway, your changes looks fine we just need:
- to add a test in recents_db_test.js "Two calls, different group because of different type" (you can get inspiration from the test checking that a different number will cause a different group)
- make the linter happy

Cheers!

Comment 3

[Borja Salguero [:borjasalguero]]

Ok, I will create the test. Trust me that the new code of the call log is quite simple, and we are gonna reduce all re-renderings that we had. Performance it's better, and the code readable :). I will come back with the test and once we have it I will ask for your feedback about call-log proposal. Thanks!

Comment 4

[Borja Salguero [:borjasalguero]]

Will be addressed in bug 848027. Duplicated.