854904 - UnixSocket: sockaddr_in, sockaddr_in6 not defined in UnixSocket.h

Status: RESOLVED FIXED

(Core :: DOM: Device Interfaces, defect)

Description

[Vicamo Yang [:vicamo][:vyang]]

Attachment: compiler error messages

In file included from ipc/unixsocket/UnixSocket.cpp:7:0:
ipc/unixsocket/UnixSocket.h:30:3: error: 'sockaddr_in' does not name a type
ipc/unixsocket/UnixSocket.h:31:3: error: 'sockaddr_in6' does not name a type

Comment 1

[Vicamo Yang [:vicamo][:vyang]]

Attachment: mozconfig

Comment 2

[Vicamo Yang [:vicamo][:vyang]]

Attachment: patch

verifying ...

Comment 3

[Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)]

Comment on attachment 729568 [details] [diff] [review]
patch

Review of attachment 729568 [details] [diff] [review]:
-----------------------------------------------------------------

Sorry about that, had this patch done but guess this only got merged to b2g18.

Comment 4

[Vicamo Yang [:vicamo][:vyang]]

Attachment: patch

Re-gen from hg. Will push when inbound re-open again.

Comment 5

[Vicamo Yang [:vicamo][:vyang]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/508256893af7

Comment 6

[Vicamo Yang [:vicamo][:vyang]]

(In reply to Kyle Machulis [:kmachulis] [:qdot] from comment #3)
> Sorry about that, had this patch done but guess this only got merged to b2g18.

Never mind. Just a little bit curious, am I the only person affected? I'm on Ubutu 13.04 beta. Probably the reason why I'm the only victim here. Will nominate for leo+/tef+ when this affects others as well.

Comment 7

[Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)]

It's already tef+'d and landed, as of 

https://bugzilla.mozilla.org/show_bug.cgi?id=843868#c35

I just didn't get it into m-c. This should fix it for all platforms.

And it probably didn't get seen because... actually I'm not really sure why. That should've blown up when building for desktop on 12.04 too I though. We get away with it on gonk because we get in.h from another header somewhere.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/508256893af7