Closed Bug 854914 Opened 7 years ago Closed 7 years ago

Allow clang to build in C++11 mode

Categories

(Firefox Build System :: General, defect)

Product:
Firefox Build System
Component:
General
Platform:
All
Linux
Type:
defect
Priority:
Not set

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
mozilla22

People

(Reporter: glandium, Assigned: glandium)

Details

Attachments

(1 file, 1 obsolete file)

Allow clang to build in C++11 mode by working around http://llvm.org/bugs/show_bug.cgi?id=13530
2.01 KB, patch
ted
: review+
Details | Diff | Splinter Review 
Comment on attachment 729584 [details] [diff] [review]
Allow clang to build in C++11 mode by working around http://llvm.org/bugs/show_bug.cgi?id=13530

Grah, this obviously doesn't survive a re-configure with config.cache.
Attachment #729584 - Flags: review?(ted)
Comment on attachment 729584 [details] [diff] [review]
Allow clang to build in C++11 mode by working around http://llvm.org/bugs/show_bug.cgi?id=13530

Review of attachment 729584 [details] [diff] [review]:
-----------------------------------------------------------------

::: configure.in
@@ +2715,5 @@
>          [AC_TRY_COMPILE([#include <memory>], [],
> +                        CXXFLAGS="$CXXFLAGS -I$_topsrcdir/build/unix/headers"
> +                        AC_TRY_COMPILE([#include <memory>], [],
> +                                       ac_cv_cxx0x_headers_bug="no",
> +                                       ac_cv_cxx0x_headers_bug="yes"),

Seems a little weird to shove this test into this other test. I think it'd be clearer if you split it out into its own test, and noted what you're testing for.
Attachment #729584 - Attachment is obsolete: true
Attachment #729681 - Flags: review?(ted) → review+
https://hg.mozilla.org/mozilla-central/rev/2ab72bbb04db
Status: NEW → RESOLVED
Closed: 7 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → mozilla22
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.