854914 - Allow clang to build in C++11 mode

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Mike Hommey [:glandium]]

Work around http://llvm.org/bugs/show_bug.cgi?id=13530.

Comment 1

[Mike Hommey [:glandium]]

Attachment: Allow clang to build in C++11 mode by working around http://llvm.org/bugs/show_bug.cgi?id=13530

Comment 2

[Mike Hommey [:glandium]]

Comment on attachment 729584 [details] [diff] [review]
Allow clang to build in C++11 mode by working around http://llvm.org/bugs/show_bug.cgi?id=13530

Grah, this obviously doesn't survive a re-configure with config.cache.

Comment 3

[(not currently active) Ted Mielczarek]

Comment on attachment 729584 [details] [diff] [review]
Allow clang to build in C++11 mode by working around http://llvm.org/bugs/show_bug.cgi?id=13530

Review of attachment 729584 [details] [diff] [review]:
-----------------------------------------------------------------

::: configure.in
@@ +2715,5 @@
>          [AC_TRY_COMPILE([#include <memory>], [],
> +                        CXXFLAGS="$CXXFLAGS -I$_topsrcdir/build/unix/headers"
> +                        AC_TRY_COMPILE([#include <memory>], [],
> +                                       ac_cv_cxx0x_headers_bug="no",
> +                                       ac_cv_cxx0x_headers_bug="yes"),

Seems a little weird to shove this test into this other test. I think it'd be clearer if you split it out into its own test, and noted what you're testing for.

Comment 4

[Mike Hommey [:glandium]]

Attachment: Allow clang to build in C++11 mode by working around http://llvm.org/bugs/show_bug.cgi?id=13530

Comment 5

[Mike Hommey [:glandium]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/2ab72bbb04db

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/2ab72bbb04db