Closed Bug 854921 Opened 8 years ago Closed 8 years ago

test slaves can't find tests.ini

Categories

(Firefox for Metro Graveyard :: Tests, defect)

x86_64
Windows 7
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 22

People

(Reporter: jimm, Assigned: jimm)

References

Details

Attachments

(2 files)

metrotestharness creates this file in it's working directory, which on the test slaves is in the utilitypath. Firefox on the other hand looks in the gre dir. We should move this file to the system's temp directory.
Hmm, actually I'm not comfortable moving this to temp, since we always check
it on startup, and anybody can create temp files.
Two fixes here - 

1) pass the path to the firefox bin to metrotestharness so it knows where to write out the tests.ini file.
2) package metro tests in the tests.jar file we distribute in test zips
Assignee: nobody → jmathies
Attachment #729710 - Flags: review?(mbrubeck)
Attached patch harness fixSplinter Review
Pickup the new firefoxpath cmd line variable passed to test harness and write the tests.ini file to that location. Also added better cleanup up of the ini file after tests run.
Attachment #729711 - Flags: review?(netzen)
Comment on attachment 729710 [details] [diff] [review]
tests automation fix

Review of attachment 729710 [details] [diff] [review]:
-----------------------------------------------------------------

::: testing/mochitest/Makefile.in
@@ +176,5 @@
>  stage-chromejar:
>  	$(NSINSTALL) -D $(PKG_CHROMEJAR)
>  	cp -RL $(DEPTH)/_tests/testing/mochitest/browser $(PKG_CHROMEJAR)
>  	cp -RL $(DEPTH)/_tests/testing/mochitest/chrome $(PKG_CHROMEJAR)
> +	cp -RL $(DEPTH)/_tests/testing/mochitest/metro $(PKG_CHROMEJAR)

I should probably wrap this in MOZ_METRO.
Attachment #729710 - Flags: review?(mbrubeck) → review+
Comment on attachment 729711 [details] [diff] [review]
harness fix

Review of attachment 729711 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/metro/shell/testing/metrotestharness.cpp
@@ +219,1 @@
>    HANDLE hTestFile = CreateFileA(testFilePath, GENERIC_WRITE,

Can we scrap the Delete File RAII helper and just use FILE_FLAG_DELETE_ON_CLOSE on the attributes of CreateFile and use nsAutoHandle from nsWindowsHelpers to take care of always closing that handle?
Attachment #729711 - Flags: review?(netzen)
Comment on attachment 729711 [details] [diff] [review]
harness fix

Seems you can't use nsAutoHandle because of moz allocators, would have been much cleaner that way, but since you can't I'm fine with this.
Attachment #729711 - Flags: review+
https://hg.mozilla.org/mozilla-central/rev/bbaf5b6ab7b3
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 22
You need to log in before you can comment on or make changes to this bug.