Closed Bug 854924 Opened 7 years ago Closed 7 years ago

Change "can't allocate graphics resources" from NS_ERROR to NS_WARNING

Categories

(Core :: IPC, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla22
blocking-b2g tef+
Tracking Status
firefox20 --- wontfix
firefox21 --- wontfix
firefox22 --- fixed
b2g18 --- fixed
b2g18-v1.0.0 --- wontfix
b2g18-v1.0.1 --- fixed

People

(Reporter: justin.lebar+bug, Assigned: justin.lebar+bug)

References

Details

Attachments

(1 file)

If a remote iframe tries to Show() itself after it's been removed from the DOM, we print an NS_ERROR and kill the subprocess.

Killing it is OK, but printing an NS_ERROR causes mochitests to fail.  The mochitest isn't doing anything wrong, and I don't think the subprocess is either.  So I'd like to change this to a warning.
Attached patch Patch, v1Splinter Review
Attachment #729589 - Flags: review?
Attachment #729589 - Flags: review? → review?(bent.mozilla)
Blocks: 852847
Comment on attachment 729589 [details] [diff] [review]
Patch, v1

Review of attachment 729589 [details] [diff] [review]:
-----------------------------------------------------------------

Sounds reasonable to me. (In my opinion all NS_ERROR/NS_ASSERTION should be fatal just like MOZ_ASSERT, so if this condition can actually happen it should be a warning.)
Attachment #729589 - Flags: review?(bent.mozilla) → review+
tef? because this indirectly blocks a blocker.  This simple change is not risky.
blocking-b2g: --- → tef?
blocking-b2g: tef? → tef+
Assignee: nobody → justin.lebar+bug
https://hg.mozilla.org/mozilla-central/rev/5c230db2b247
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla22
You need to log in before you can comment on or make changes to this bug.