Change "can't allocate graphics resources" from NS_ERROR to NS_WARNING

RESOLVED FIXED in Firefox 22

Status

()

RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: justin.lebar+bug, Assigned: justin.lebar+bug)

Tracking

Trunk
mozilla22
Points:
---

Firefox Tracking Flags

(blocking-b2g:tef+, firefox20 wontfix, firefox21 wontfix, firefox22 fixed, b2g18 fixed, b2g18-v1.0.0 wontfix, b2g18-v1.0.1 fixed)

Details

Attachments

(1 attachment)

If a remote iframe tries to Show() itself after it's been removed from the DOM, we print an NS_ERROR and kill the subprocess.

Killing it is OK, but printing an NS_ERROR causes mochitests to fail.  The mochitest isn't doing anything wrong, and I don't think the subprocess is either.  So I'd like to change this to a warning.
Created attachment 729589 [details] [diff] [review]
Patch, v1
Attachment #729589 - Flags: review?
(Assignee)

Updated

6 years ago
Attachment #729589 - Flags: review? → review?(bent.mozilla)
(Assignee)

Updated

6 years ago
Blocks: 852847
Comment on attachment 729589 [details] [diff] [review]
Patch, v1

Review of attachment 729589 [details] [diff] [review]:
-----------------------------------------------------------------

Sounds reasonable to me. (In my opinion all NS_ERROR/NS_ASSERTION should be fatal just like MOZ_ASSERT, so if this condition can actually happen it should be a warning.)
Attachment #729589 - Flags: review?(bent.mozilla) → review+
tef? because this indirectly blocks a blocker.  This simple change is not risky.
blocking-b2g: --- → tef?
blocking-b2g: tef? → tef+
status-b2g18: --- → affected
status-b2g18-v1.0.1: --- → affected
Assignee: nobody → justin.lebar+bug
https://hg.mozilla.org/mozilla-central/rev/5c230db2b247
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla22
https://hg.mozilla.org/releases/mozilla-b2g18/rev/08eeda248760
https://hg.mozilla.org/releases/mozilla-b2g18_v1_0_1/rev/4dfa4d05e3b9
status-b2g18: affected → fixed
status-b2g18-v1.0.0: --- → wontfix
status-b2g18-v1.0.1: affected → fixed
status-firefox20: --- → wontfix
status-firefox21: --- → wontfix
status-firefox22: --- → fixed
You need to log in before you can comment on or make changes to this bug.