854924 - Change "can't allocate graphics resources" from NS_ERROR to NS_WARNING

Status: RESOLVED FIXED

(Core :: IPC, defect)

Description

[Justin Lebar (not reading bugmail)]

If a remote iframe tries to Show() itself after it's been removed from the DOM, we print an NS_ERROR and kill the subprocess.

Killing it is OK, but printing an NS_ERROR causes mochitests to fail.  The mochitest isn't doing anything wrong, and I don't think the subprocess is either.  So I'd like to change this to a warning.

Comment 1

[Justin Lebar (not reading bugmail)]

Attachment: Patch, v1

Comment 2

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Comment on attachment 729589 [details] [diff] [review]
Patch, v1

Review of attachment 729589 [details] [diff] [review]:
-----------------------------------------------------------------

Sounds reasonable to me. (In my opinion all NS_ERROR/NS_ASSERTION should be fatal just like MOZ_ASSERT, so if this condition can actually happen it should be a warning.)

Comment 3

[Justin Lebar (not reading bugmail)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/5c230db2b247

Comment 4

[Justin Lebar (not reading bugmail)]

tef? because this indirectly blocks a blocker.  This simple change is not risky.

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/5c230db2b247

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-b2g18/rev/08eeda248760
https://hg.mozilla.org/releases/mozilla-b2g18_v1_0_1/rev/4dfa4d05e3b9