854951 - Contacts which only have email defined are displayed as blank in contacts list

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Description

[Jose Manuel Cantera]

It is needed to fix the issue described in the title by fixing the logic in the Contacts App.

Comment 1

[Cristian Rodriguez (:crdlc)]

I guess that the same problem is reproducible for gmail friends

Comment 2

[Cristian Rodriguez (:crdlc)]

Attachment: Patch v1

Comment 3

[Cristian Rodriguez (:crdlc)]

I've implemented Cantera's suggestions, are you ok with this patch Alberto?

Comment 4

[alberto.pastor]

Thanks Cristian. I'm ok with the patch, but can we just take advantage of this bug for adding a small unit test for this case? Thanks!

Comment 5

[alberto.pastor]

@Cristian, I sent you a Pull Request

Comment 6

[Cristian Rodriguez (:crdlc)]

Sorry but github says: this pull request cannot be automatically merged

Comment 7

[Jose Manuel Cantera]

https://github.com/mozilla-b2g/gaia/commit/cd12f41624c7adab54ab84843b34e54ac1420aff

Comment 8

[Jose Manuel Cantera]

We have verified that this problem may also occur in v1.0.1 indpendently of Hotmail, thus we need to uplift this bug also to v1.0.1, thus nominating it.

Comment 9

[Cristian Rodriguez (:crdlc)]

What does in-moztrap mean? thanks

Comment 10

[Maria Angeles Oteo (:oteo)]

(In reply to Cristian Rodriguez (a tope!) from comment #9)
> What does in-moztrap mean? thanks

It is the Mozilla tool for the the test coverage, I think it's not a question for you but for QA people :)

Comment 11

[John Ford [:jhford] CET/CEST Berlin Time]

Uplifted commit cd12f41624c7adab54ab84843b34e54ac1420aff as:
v1-train: ad6275322951bbbcd7f3ceeaf086cd4452dc4b8e
v1.0.1: a9f26ea3061f6fff1410c640856d986d6ed899cd

Comment 12

[Mila Davydova]

Issue no longer reproduces on Unagi device
Build ID: 20130403070204
Kernel Date: Dec 5
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/d467369d1b0c
Gaia: 06e0e5ce42bdfb62bdbe38271de6b5b2d9e40e75


also, issue appears fixed on Build ID: 20130403070201
Kernel Date: Dec 5
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18_v1_0_1/rev/512258bc00a3
Gaia: daea430624ec02f8d36a12d581fc4a3278c27cb7

Contacts which only have email defined no longer display as blank in contacts list. Email address is displayed in the contacts list, for the contact that have only email address defined.
Verified fixed