854999 - Paris binding for SimpleGestureEvent

Status: RESOLVED FIXED

(Core :: DOM: Events, defect)

Description

[Olli Pettay [:smaug][[e-mail]]]

Attachment: patch

For now keep the documentation in one place.

https://tbpl.mozilla.org/?tree=Try&rev=8b2841a357e2

Comment 1

[Olli Pettay [:smaug][[e-mail]]]

Erm, init* should be with [Throws]

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

Attachment: v2

https://tbpl.mozilla.org/?tree=Try&rev=e7ac3661d23d

Comment 3

[Peter Van der Beken [:peterv]]

Comment on attachment 729707 [details] [diff] [review]
v2

Review of attachment 729707 [details] [diff] [review]:
-----------------------------------------------------------------

::: content/events/src/nsDOMSimpleGestureEvent.h
@@ +59,5 @@
> +                              bool aAltKey,
> +                              bool aShiftKey,
> +                              bool aMetaKey,
> +                              uint16_t aButton,
> +                              nsIDOMEventTarget* aRelatedTarget,

mozilla::dom::EventTarget?

Comment 4

[Peter Van der Beken [:peterv]]

Comment on attachment 729707 [details] [diff] [review]
v2

Review of attachment 729707 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/webidl/SimpleGestureEvent.webidl
@@ +24,5 @@
> +
> +  readonly attribute unsigned long clickCount;
> +
> +  [Throws]
> +  void initSimpleGestureEvent(DOMString typeArg,

Also, please do s/Arg// on all these arguments.

Comment 5

[Olli Pettay [:smaug][[e-mail]]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/390e9d43975a

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/390e9d43975a