If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Paris binding for SimpleGestureEvent

RESOLVED FIXED in mozilla22

Status

()

Core
DOM: Events
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: smaug, Assigned: smaug)

Tracking

unspecified
mozilla22
x86_64
Linux
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

5 years ago
Created attachment 729697 [details] [diff] [review]
patch

For now keep the documentation in one place.

https://tbpl.mozilla.org/?tree=Try&rev=8b2841a357e2
Attachment #729697 - Flags: review?(peterv)
(Assignee)

Comment 1

5 years ago
Erm, init* should be with [Throws]
(Assignee)

Comment 2

5 years ago
Created attachment 729707 [details] [diff] [review]
v2

https://tbpl.mozilla.org/?tree=Try&rev=e7ac3661d23d
Attachment #729697 - Attachment is obsolete: true
Attachment #729697 - Flags: review?(peterv)
Attachment #729707 - Flags: review?(peterv)
(Assignee)

Updated

5 years ago
Blocks: 776864
Comment on attachment 729707 [details] [diff] [review]
v2

Review of attachment 729707 [details] [diff] [review]:
-----------------------------------------------------------------

::: content/events/src/nsDOMSimpleGestureEvent.h
@@ +59,5 @@
> +                              bool aAltKey,
> +                              bool aShiftKey,
> +                              bool aMetaKey,
> +                              uint16_t aButton,
> +                              nsIDOMEventTarget* aRelatedTarget,

mozilla::dom::EventTarget?
Attachment #729707 - Flags: review?(peterv) → review+
Comment on attachment 729707 [details] [diff] [review]
v2

Review of attachment 729707 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/webidl/SimpleGestureEvent.webidl
@@ +24,5 @@
> +
> +  readonly attribute unsigned long clickCount;
> +
> +  [Throws]
> +  void initSimpleGestureEvent(DOMString typeArg,

Also, please do s/Arg// on all these arguments.
(Assignee)

Comment 5

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/390e9d43975a
https://hg.mozilla.org/mozilla-central/rev/390e9d43975a
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla22
You need to log in before you can comment on or make changes to this bug.