855030 - Parser.jsm should support fat arrow functions

Status: RESOLVED FIXED

(DevTools :: Debugger, defect, P3)

Comment 1

[Victor Porof [:vporof][:vp]]

Attachment: v1

Comment 2

[Victor Porof [:vporof][:vp]]

Update documentation: https://developer.mozilla.org/en-US/docs/SpiderMonkey/Parser_API$compare?to=371789&from=342141

Comment 3

[Panos Astithas (he/him) [:past] (please ni?)]

Comment on attachment 729741 [details] [diff] [review]
v1

Review of attachment 729741 [details] [diff] [review]:
-----------------------------------------------------------------

That was fast!

::: browser/devtools/shared/Parser.jsm
@@ +1559,5 @@
>    /**
> +   * An arrow expression.
> +   *
> +   * interface FunctionExpression <: Function, Expression {
> +   *   type: "FunctionExpression";

ArrowExpression in both places.

@@ +1568,5 @@
> +   *   generator: boolean;
> +   *   expression: boolean;
> +   * }
> +   */
> +  ArrowExpression: function STV_ArrowExpression(aNode, aParent, aCallbacks) {

You could make FunctionExpression call this one to cut down on code size, but I think the whole file could use a similar refactoring, so we could do it in a followup.

Comment 4

[Victor Porof [:vporof][:vp]]

(In reply to Panos Astithas [:past] from comment #3)
> 
> You could make FunctionExpression call this one to cut down on code size,
> but I think the whole file could use a similar refactoring, so we could do
> it in a followup.

Theoretically yes, I could even reduce both ArrowExpression and FunctionExpression to call FunctionDeclaration, as long as I don't always assume that they have a non-null identifier, but you never know how these language features may evolve, so I think the DRY approach is less pertinent here. Let's see what happens wrt thin arrow functions (if that ever becomes a reality), how the spec evolves etc.

Comment 5

[Victor Porof [:vporof][:vp]]

Attachment: v1.1

s/Function/Arrow/

Comment 6

[Victor Porof [:vporof][:vp]]

https://hg.mozilla.org/integration/fx-team/rev/d68b52ce9322

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/d68b52ce9322