Closed Bug 855048 Opened 10 years ago Closed 10 years ago

nsRangeFrame shouldn't init the "nsReflowStatus frameStatus" that it passes into ReflowChild

Categories

(Core :: Layout, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla22

People

(Reporter: dholbert, Assigned: jwatt)

References

Details

Attachments

(1 file)

nsRangeFrame::ReflowAnonymousContent() has several instances of:
    nsReflowStatus frameStatus = NS_FRAME_COMPLETE;
    nsresult rv = ReflowChild(...frameStatus);

frameStatus is an outparam in ReflowChild, so we shouldn't be initializing it here.

Per bug 838256 comment 26, nsRangeFrame has it this way because that's how nsContainerFrame did it at the time -- but since then, I've fixed nsContainerFrame (in bug 842080).  We should fix nsRangeFrame too.
Attached patch patchSplinter Review
Assignee: nobody → jwatt
Attachment #730107 - Flags: review?(dholbert)
Attachment #730107 - Flags: review?(dholbert) → review+
https://hg.mozilla.org/mozilla-central/rev/04e984b6b5e0
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla22
You need to log in before you can comment on or make changes to this bug.