Closed
Bug 855048
Opened 11 years ago
Closed 11 years ago
nsRangeFrame shouldn't init the "nsReflowStatus frameStatus" that it passes into ReflowChild
Categories
(Core :: Layout, defect)
Core
Layout
Tracking
()
RESOLVED
FIXED
mozilla22
People
(Reporter: dholbert, Assigned: jwatt)
References
Details
Attachments
(1 file)
|
3.40 KB,
patch
|
dholbert
:
review+
|
Details | Diff | Splinter Review |
nsRangeFrame::ReflowAnonymousContent() has several instances of:
nsReflowStatus frameStatus = NS_FRAME_COMPLETE;
nsresult rv = ReflowChild(...frameStatus);
frameStatus is an outparam in ReflowChild, so we shouldn't be initializing it here.
Per bug 838256 comment 26, nsRangeFrame has it this way because that's how nsContainerFrame did it at the time -- but since then, I've fixed nsContainerFrame (in bug 842080). We should fix nsRangeFrame too.
|
Assignee | |
Comment 1•11 years ago
|
||
Assignee: nobody → jwatt
Attachment #730107 -
Flags: review?(dholbert)
|
Reporter | |
Updated•11 years ago
|
Attachment #730107 -
Flags: review?(dholbert) → review+
|
|
Assignee | |
Comment 2•11 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/04e984b6b5e0
|
||
Comment 3•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/04e984b6b5e0
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla22
You need to log in
before you can comment on or make changes to this bug.
Description
•