handle account name that is a substring of another one properly in the activity manager

RESOLVED FIXED in Thunderbird 23.0

Status

Thunderbird
Mail Window Front End
--
minor
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: aceman, Assigned: aceman)

Tracking

Trunk
Thunderbird 23.0

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

4 years ago
In mail/components/activity/modules/autosync.js there is this code:

    for (let i = 1; i < this._inQFolderList.length; i++) {
      // do not include already existing account names
      if (!accountList.contains(this._inQFolderList[i].server.prettyName))
        accountList = accountList + ", " + this._inQFolderList[i].server.prettyName;
    }

This is not a proper way to exclude duplicate names as account names can be substrings of each other.
(Assignee)

Comment 1

4 years ago
Created attachment 729819 [details] [diff] [review]
patch
Attachment #729819 - Flags: review?(mconley)
Comment on attachment 729819 [details] [diff] [review]
patch

Review of attachment 729819 [details] [diff] [review]:
-----------------------------------------------------------------

Yes, this is much better. Thanks aceman!
Attachment #729819 - Flags: review?(mconley) → review+
(Assignee)

Updated

4 years ago
Keywords: checkin-needed
https://hg.mozilla.org/comm-central/rev/aaca24426463
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 23.0
You need to log in before you can comment on or make changes to this bug.