Closed
Bug 855057
Opened 11 years ago
Closed 11 years ago
handle account name that is a substring of another one properly in the activity manager
Categories
(Thunderbird :: Mail Window Front End, defect)
Thunderbird
Mail Window Front End
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 23.0
People
(Reporter: aceman, Assigned: aceman)
Details
Attachments
(1 file)
|
2.63 KB,
patch
|
mconley
:
review+
|
Details | Diff | Splinter Review |
In mail/components/activity/modules/autosync.js there is this code:
for (let i = 1; i < this._inQFolderList.length; i++) {
// do not include already existing account names
if (!accountList.contains(this._inQFolderList[i].server.prettyName))
accountList = accountList + ", " + this._inQFolderList[i].server.prettyName;
}
This is not a proper way to exclude duplicate names as account names can be substrings of each other.
Attachment #729819 -
Flags: review?(mconley)
|
||
Comment 2•11 years ago
|
||
Comment on attachment 729819 [details] [diff] [review] patch Review of attachment 729819 [details] [diff] [review]: ----------------------------------------------------------------- Yes, this is much better. Thanks aceman!
Attachment #729819 -
Flags: review?(mconley) → review+
Keywords: checkin-needed
|
||
Comment 3•11 years ago
|
||
https://hg.mozilla.org/comm-central/rev/aaca24426463
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 23.0
You need to log in
before you can comment on or make changes to this bug.
Description
•