Status

RESOLVED FIXED
6 years ago
27 days ago

People

(Reporter: mark.yen, Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

6 years ago
Created attachment 729805 [details] [diff] [review]
patch

Bug 852950 will kill libxpcom; we'll need to link against libxul instead.  Attached patch can get us to successful-looking `make check`.

This also includes nsCAutoString -> nsAutoCString changes and nsresult != unsigned long changes; basically, everything needed to build against ~ m-c from when libxpcom killing initially landed (before being backed out).
Attachment #729805 - Flags: review?(toddw)

Comment 1

6 years ago
Comment on attachment 729805 [details] [diff] [review]
patch

Please commit as two separate changes - one for libxul, the other for nsCAutoString -> nsAutoCString changes and nsresult != unsigned long changes.

Also, make sure we have proper pyxpcom version tags/branches before committing.
Attachment #729805 - Flags: review?(toddw) → review+
(Reporter)

Comment 2

6 years ago
Todd went and checked in https://hg.mozilla.org/pyxpcom/rev/ba1f14b67538 and related changes.  I'm assuming that fixed things.
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED

Updated

27 days ago
Product: Other Applications → Other Applications Graveyard
You need to log in before you can comment on or make changes to this bug.