Closed Bug 855109 Opened 7 years ago Closed 7 years ago

configure.in mixes up CXX vs. c when defining -Wsign-compare

Categories

(Firefox Build System :: General, defect)

x86_64
Linux
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
mozilla22

People

(Reporter: dholbert, Assigned: dholbert)

References

Details

Attachments

(1 file)

[Section for C code:]
> 1344 if test "$GNU_CC"; then
> 1425     MOZ_C_SUPPORTS_WARNING(-W, error=return-type, ac_c_has_werror_return_type)
> 1426     MOZ_C_SUPPORTS_WARNING(-W, type-limits, ac_c_has_wtype_limits)
> 1427     MOZ_C_SUPPORTS_WARNING(-W, empty-body, ac_c_has_wempty_body)
> 1428     MOZ_C_SUPPORTS_WARNING(-W, sign-compare, ac_c_has_sign_compare)
[Section for C++ code:]
> 1475 if test "$GNU_CXX"; then
> 1488     _WARNINGS_CXXFLAGS="${_WARNINGS_CXXFLAGS} -Wall -Wpointer-arith -Woverloaded-virtual"
> 1489     MOZ_CXX_SUPPORTS_WARNING(-W, error=return-type, ac_cxx_has_werror_return_type)
> 1490     MOZ_CXX_SUPPORTS_WARNING(-W, type-limits, ac_cxx_has_wtype_limits)
> 1491     MOZ_CXX_SUPPORTS_WARNING(-W, empty-body, ac_cxx_has_wempty_body)
> 1492     MOZ_CXX_SUPPORTS_WARNING(-W, sign-compare, ac_c_has_sign_compare)
https://mxr.mozilla.org/mozilla-central/source/configure.in#1492

I don't claim to know exactly what's going on under the hood here, but that last line looks wrong.

I think it wants to have "ac_cxx_has_sign_compare" (note the "xx"), not "ac_c_has_sign_compare", for consistency.
Turns out this line was added very recently, in https://hg.mozilla.org/mozilla-central/rev/2a450024df4e , for bug 849995.
Blocks: 849995
Attached patch fixSplinter Review
Assignee: nobody → dholbert
Status: NEW → ASSIGNED
Attachment #729854 - Flags: review?(mh+mozilla)
Blocks: 853874
Attachment #729854 - Flags: review?(mh+mozilla) → review+
Flags: in-testsuite-
https://hg.mozilla.org/mozilla-central/rev/554c4124d5ea
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla22
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.