855175 - [Contacts] Add contact: After clicked an input field and switched to the Lable page directly, the keyboard did not hide.

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Description

[Evan Tseng [:evanxd]]

Attachment: STR Video

STR:

1. Go to the Add contact page.

2. Click an input field, like Phone field.
   (The keyboard show up.)

3. Directly, click the MOBILE Label item.

Expected:
The keyboard was hidden, and switched to the Label page.

Result:
The keyboard didn't hide, then switched to the Label page.

Comment 1

[Evan Tseng [:evanxd]]

We used the mozKeyboard API to remove the focus in the goToSelectTag function.
See the code:
https://github.com/mozilla-b2g/gaia/blob/master/apps/communications/contacts/js/contacts.js#L404

But we didn't defined the keyboard permission in the manifest.webapp.
See the code:
https://github.com/mozilla-b2g/gaia/blob/master/apps/communications/manifest.webapp#L69

we need to define a keyboard permission in the manifest.webapp, and the issue will be solved.

Comment 2

[Evan Tseng [:evanxd]]

Attachment: Pointer to GitHub pull request: https://github.com/mozilla-b2g/gaia/pull/8842

Thanks :)

Comment 3

[Daniel Coloma:dcoloma]

I can reproduce it in v1.0.1 but is not a blocker in my opinion. I'd suggest we land it in master once it gets r+ and request approval for uplifting to v1.1

Comment 4

[alberto.pastor]

https://github.com/mozilla-b2g/gaia/commit/8fc1b68d4018ad7d9dad272426b19e576189ac4f

Comment 5

[alberto.pastor]

Comment on attachment 730045 [details]
Pointer to GitHub pull request: https://github.com/mozilla-b2g/gaia/pull/8842

NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 
User impact if declined: 
Testing completed: 
Risk to taking this patch (and alternatives if risky): One liner that avoid they keyboard when going to the labels view
String or UUID changes made by this patch:

Comment 6

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Hi Evan, 

I think it is not that appropriate for a non-keyboard app to use keyboard API.
Is it possible for that element we clicked to get the focus from the input? 
(Right now, it would not because we do "preventDefault()" in onGoToSelectTag() function of contacts_form.js.)

What do you think?

Comment 7

[Alex Keybl [:akeybl]]

Comment on attachment 730045 [details]
Pointer to GitHub pull request: https://github.com/mozilla-b2g/gaia/pull/8842

We'll reconsider after comment 6 is addressed (not clear if that should block uplift).

Comment 8

[Evan Tseng [:evanxd]]

Hi Rudy,

I think you have a good point.

I'll follow up that to figure out why we use preventDefault() in the onGoToSelectTag() function.

Comment 9

[John Ford [:jhford] CET/CEST Berlin Time]

Uplifted commit 8fc1b68d4018ad7d9dad272426b19e576189ac4f as:
v1-train: f391a5f297e2519a0c9a981f6dd43433dba47e50

Comment 10

[Evelyn Hung]

(In reply to Evan Tseng from comment #8)
> Hi Rudy,
> 
> I think you have a good point.
> 
> I'll follow up that to figure out why we use preventDefault() in the
> onGoToSelectTag() function.

Hi Even, any update of this problem? I think this is an abuse of mozKeyboard API.
Please file a follow-up issue for tracking, we should fix it.

Comment 11

[Evan Tseng [:evanxd]]

Hi Evelyn,

I just created a bug for this issue.
http://bugzil.la/859201

And I'll fix the issue.

Thanks. :)