855178 - Use WaitSync instead of ClientWaitSync in SharedSurfaceGL

Status: RESOLVED FIXED

(Core :: Graphics: CanvasWebGL, defect)

Description

[Jeff Muizelaar [:jrmuizel]]

Attachment: Use WaitSync instead of ClientWaitSync in SharedSurfaceGL

This is better than waiting/spinning.

Comment 1

[Kelsey Gilbert [:jgilbert]]

Comment on attachment 729970 [details] [diff] [review]
Use WaitSync instead of ClientWaitSync in SharedSurfaceGL

Review of attachment 729970 [details] [diff] [review]:
-----------------------------------------------------------------

Fix the indentation and we're good to go!

Comment 2

[Kelsey Gilbert [:jgilbert]]

This needs the relevant MakeCurrent calls in the right places, as well.

Comment 3

[Kelsey Gilbert [:jgilbert]]

Comment on attachment 729970 [details] [diff] [review]
Use WaitSync instead of ClientWaitSync in SharedSurfaceGL

Forgot that we'll have to change/add MakeCurrent such that we're on the correct context, here.

Comment 4

[Phil Ringnalda (:philor)]

Backed out in https://hg.mozilla.org/integration/mozilla-inbound/rev/1bdcec714f37 for the assertion in https://tbpl.mozilla.org/php/getParsedLog.php?id=21146129&tree=Mozilla-Inbound

Comment 5

[Jeff Muizelaar [:jrmuizel]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/67f0f4e7d3ff

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/67f0f4e7d3ff