Closed Bug 855180 Opened 11 years ago Closed 11 years ago

Intermittent browser_toolbar_webconsole_errors_count.js | Timed out while waiting for: web console shows the page errors followed by other timeouts, failures, leaks

Categories

(DevTools :: Console, defect)

Product:
DevTools
Component:
Console
Platform:
x86
Windows XP
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
Firefox 24

People

(Reporter: philor, Assigned: msucan)

Details

(Keywords: intermittent-failure)

Attachments

(1 file)

proposed fix
12.17 KB, patch
jwalker
: review+
Details | Diff | Splinter Review 
https://tbpl.mozilla.org/php/getParsedLog.php?id=21135404&tree=Mozilla-Inbound
Rev3 WINNT 5.1 mozilla-inbound debug test mochitest-browser-chrome on 2013-03-26 17:11:03 PDT for push d4239df4eac9
slave: talos-r3-xp-032

18:12:05     INFO -  TEST-INFO | chrome://mochitests/content/browser/browser/devtools/shared/test/browser_toolbar_webconsole_errors_count.js | Console message: [JavaScript Warning: "ReferenceError: reference to undefined property aItem.type" {file: "chrome://browser/content/devtools/webconsole.js" line: 2272}]
18:12:05  WARNING -  TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/devtools/shared/test/browser_toolbar_webconsole_errors_count.js | Timed out while waiting for: web console shows the page errors
18:12:05     INFO -  Stack trace:
18:12:05     INFO -      JS frame :: chrome://mochitests/content/browser/browser/devtools/shared/test/head.js :: wait :: line 89
18:12:05     INFO -      JS frame :: chrome://mochitests/content/browser/browser/devtools/shared/test/head.js :: <TOP_LEVEL> :: line 107
18:12:05     INFO -      native frame :: <unknown filename> :: <TOP_LEVEL> :: line 0
18:12:05     INFO -  TEST-INFO | chrome://mochitests/content/browser/browser/devtools/shared/test/browser_toolbar_webconsole_errors_count.js | timeout info :: got '0', expected '4'
...
18:13:06  WARNING -  TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/devtools/styleeditor/test/browser_styleeditor_cmd_edit.js | Test timed out
18:18:43  WARNING -  TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/devtools/webconsole/test/browser_webconsole_bug_603750_websocket.js | received a Web Socket error - Got FrameConstructor, expected Web Socket
18:18:43  WARNING -  TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/devtools/webconsole/test/browser_webconsole_bug_603750_websocket.js | sourceName is correct - Didn't expect -1, but got it
18:45:01  WARNING -  TEST-UNEXPECTED-FAIL | leakcheck | 2167799 bytes leaked (AsyncStatement, AtomImpl, BackstagePass, CalculateFrecencyFunction, CallbackObject, ...)
This looks like mozilla-inbound carnage as well. errors_count.js test should fail gracefully without bringing down unrelated tests like those from the web console or the style editor.

The webconsole websocket.js test failure also points to inbound carnage: getting a FrameConstructor error while a test runs, instead of the expected Web Socket error.

If needed, we can leave this bug open a little longer to see if these errors show up again, just to confirm these will not repeat again.
Attached patch proposed fix — — Splinter Review 
Based on logs from tbpl I believe we hit the 5s time limit for the button update and instead of increasing the timeout I changed it to use a new toolbar event which I added in DeveloperToolbar.jsm. I also tried to cleanup the test, to make it easier to follow.

Please let me know if the toolbar code change is acceptable or if you have any other concerns. Thank you!
Assignee: nobody → mihai.sucan
Status: NEW → ASSIGNED
Attachment #752953 - Flags: review?(jwalker)
Attachment #752953 - Flags: review?(jwalker) → review+
Thanks for the quick review.

I had a green try push:
https://tbpl.mozilla.org/?tree=Try&rev=3179699b88bd

Landed in inbound:
https://hg.mozilla.org/integration/mozilla-inbound/rev/5c886ff5dbcf
https://hg.mozilla.org/mozilla-central/rev/5c886ff5dbcf
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 24
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: