855210 - use same process to handle app in 'apps', 'external-apps' and others

Status: RESOLVED FIXED

(Firefox OS Graveyard :: GonkIntegration, defect)

Description

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

Now we use two arrays to store apps and external-apps in |Gaia| of build/utils.js, we should use same way to process those two directories and other like showcase_apps, test_external_apps, dogfood_apps, etc.

main idea is put apps, external-apps and others to GAIA_APP_SRCDIRS and detect type by APP/metadata.json and APP/update.webapp.

below is pseudocode:

if metadata.json exists:
  if update.webapp exists:
    return TYPE_APP_EXTERNAL_PACKAGED
  else:
    return TYPE_APP_EXTERNAL_HOSTED
else:
  return TYPE_APP_CORE

Comment 1

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

Attachment: pull request: https://github.com/mozilla-b2g/gaia/pull/8845

Comment 2

[Donovan Preston [:fzzzy]]

The pseudocode makes sense to me. I like this approach.

Comment 3

[[:fabrice] Fabrice Desré]

Comment on attachment 730076 [details]
pull request: https://github.com/mozilla-b2g/gaia/pull/8845

Let's see if we can merge that with what's being done in bug 848604

Comment 4

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

We will do this work on bug 848604

Comment 5

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

de-duplicate from bug 848604 because I would like to send two PR for those two changes.

Comment 6

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

Comment on attachment 730076 [details]
pull request: https://github.com/mozilla-b2g/gaia/pull/8845

rebase to master and set review again.

Comment 7

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Comment on attachment 730076 [details]
pull request: https://github.com/mozilla-b2g/gaia/pull/8845

r+ with one variable rename.

Comment 8

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

Comment on attachment 730076 [details]
pull request: https://github.com/mozilla-b2g/gaia/pull/8845

Tim, I found a build failed bug with distribution dir. Cancel review flag and investigating...

Comment 9

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

root cause is we added some code with |externalAppsDirs| after rebased to master.

Comment 10

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

Comment on attachment 730076 [details]
pull request: https://github.com/mozilla-b2g/gaia/pull/8845

Okay, I updated PR again with variable rename.

root cause is we added some code with |externalAppsDirs| on bug 838098 after I rebased to master on last Thursday.

Comment 11

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

Merged.

https://github.com/yurenju/gaia/commit/0a005ac29c730c76b8c5f65b09ea6eb6b50f816e