Closed Bug 855286 Opened 7 years ago Closed 7 years ago

Fix gamepad compilation on mingw.

Categories

(Firefox Build System :: General, defect)

x86_64
Windows 7
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
mozilla22

People

(Reporter: jacek, Assigned: jacek)

Details

Attachments

(1 file)

Attached patch fixSplinter Review
The only problem there is build config. mingw-w64 provides dinput together with the rest of SDK, so we just have to skip irrevelant configure checks and add proper linking options.
Attachment #730146 - Flags: review?(ted)
Comment on attachment 730146 [details] [diff] [review]
fix

Review of attachment 730146 [details] [diff] [review]:
-----------------------------------------------------------------

Cool. Does mingw have XInput headers? We'll be adding support for that in bug 690937.
Attachment #730146 - Flags: review?(ted) → review+
Thanks for quick review! Yes, it has XInput headers, so there should be no problem once it lands.
https://hg.mozilla.org/mozilla-central/rev/91b7d9a8c226
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla22
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.