855393 - [B2G][Contacts][Facebook] The sync button forces you to log out and login again in order to synchronize your contacts.

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Description

[Darren]

Description:
After importing some Facebook contacts, there is one button sync to update the imported contacts information.

Repro Steps:
1. Open the Contacts app.
2. Tap on the Settings icon.(Gear Icon)
3. Toggle on Facebook and log into a valid account.
4. Import some contacts.

Actual Results:
There is no single button resync for Facebook contacts.

Expected Results:
If changes have been made to a Facebook contact, the user will be able to press a single button to be able to resync all imported contacts information.

Environmental  Variables:
Kernel Date: Dec 5
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/778da49486f0
Gaia: 6c3767c2dea43b5e9aff7d156d36d69649005621

Notes:
This feature would be very useful for user to be able and resync information without needing to unimport and reimport Facebook contacts.

Comment 1

[Jose Manuel Cantera]

The 'Update Facebook Friends' button on Contact Settings provide this functionality. It triggers a background synchronization of FB Friends.

Comment 2

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Reopening.  

The Sync friends button will force you to log out and relog in.  I believe he wrote this bug because it causes extra work for the end user to sync their friends contacts in the contacts app.

Rephrased the title to suit the issue more closely.  It would be better if we had something like the gmail where the sync comes with just a single tap of a button rather than relogging in.

Comment 3

[jachen]

I feel like I have discussed this (or heard second hand) about the technical feasibility of this from TEF UX.

Ayman is the best person to follow up in regards to contacts.

Comment 4

[Jose Manuel Cantera]

(In reply to Naoki Hirata :nhirata (please use needinfo instead of cc) from comment #2)
> Reopening.  
> 
> The Sync friends button will force you to log out and relog in.  I believe
> he wrote this bug because it causes extra work for the end user to sync
> their friends contacts in the contacts app.

I think you are not understanding the functionality at all. Probably because of a misleading name in he 'Sync Friends' label. When you click on the switch 'Sync Friends' you are in fact activating Facebook and if you link or import friends your friends will automatically be synchronized. If you switch off what you will do is to un-import / unlink all your friends and logout, that's the functionality implemented months ago. 

The only bug I can see here is the label 'Sync Friends' which can mislead the user so probably we would like to have a better name for that label.

To be clear the switch is not intended for the user to activate / deactivate FB Sync, it is intended to activate / deactivate FB integration with contacts. Once activated synchronization will always be happening as by contract we must do so. 

> 
> Rephrased the title to suit the issue more closely.  It would be better if
> we had something like the gmail where the sync comes with just a single tap
> of a button rather than relogging in.

Comment 5

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Thank you for the additional information.  I think you are right, Jose. I believe the label is misleading.

Comment 6

[mlevin]

In addition changes to a Facebook contact that is linked to another contact in the Contacts Application are not seen. If the workaround, as described in the Description section of bug 874124, is done the contact becomes un-linked, and the User must link it again.

Comment 8

[mlevin]

As a reply to comment 7 please note that there indeed exist a UCID that further supports this bug to be fixed, specifically:

UCID: owd-13752

Moztrap Link to the test case:
https://moztrap.mozilla.org/results/cases/?pagenumber=1&pagesize=20&sortfield=created_on&sortdirection=desc&filter-id=5164&filter-run=1301

Comment 9

[Jose Manuel Cantera]

(In reply to mlevin from comment #6)
> In addition changes to a Facebook contact that is linked to another contact
> in the Contacts Application are not seen. If the workaround, as described in
> the Description section of bug 874124, is done the contact becomes
> un-linked, and the User must link it again.

I think this was fixed by bug 884728. Please verify and close this bug.

Comment 10

[Joe Cheng [:jcheng] (please needinfo)]

listed as must have in v1.2 for COMM team. koi+

Comment 11

[:gerard-majax]

I don't understand this bug. I just tested with uptodate master on Inari, logged into Facebook, imported my contacts, and now I see a « Update imported friends ». Is this bug still valid ?

Comment 12

[Darren]

Looks like on the Inari master, after going into the "Update Imported Friends" and backing out the imported facebook friends are then updated.

Checked on -
Build ID: 20130822040202
Gecko: http://hg.mozilla.org/mozilla-central/rev/2ab07dec6404
Gaia: 2f62e3aaa1e8421e0d8e536d2b61fa69fb1bd983
Platform Version: 26.0a1

Comment 13

[:gerard-majax]

(In reply to Darren from comment #12)
> Looks like on the Inari master, after going into the "Update Imported
> Friends" and backing out the imported facebook friends are then updated.
> 
> Checked on -
> Build ID: 20130822040202
> Gecko: http://hg.mozilla.org/mozilla-central/rev/2ab07dec6404
> Gaia: 2f62e3aaa1e8421e0d8e536d2b61fa69fb1bd983
> Platform Version: 26.0a1

So I'm closing this.

Comment 14

[ayman maat :maat]

removing ni? to me as fixed