855522 - Paris binding for ClipboardEvent

Status: RESOLVED FIXED

(Core :: DOM: Events, defect)

Comment 1

[Olli Pettay [:smaug][[e-mail]]]

Attachment: patch

https://tbpl.mozilla.org/?tree=Try&rev=8160282ac742

I'm adding default values to the dict properties to get simpler code in the
C++ file. No need to check whether something was passed.

Comment 2

[Peter Van der Beken [:peterv]]

Comment on attachment 730409 [details] [diff] [review]
patch

Review of attachment 730409 [details] [diff] [review]:
-----------------------------------------------------------------

::: content/events/src/nsDOMClipboardEvent.cpp
@@ +70,5 @@
>      if (event) {
>        // Always create a clipboardData for the copy event. If this is changed to
>        // support other types of events, make sure that read/write privileges are
>        // checked properly within nsDOMDataTransfer.
> +      // If you change this, change also Constructor!

... then also change Constructor!

But I have to ask, why can't InitClipboardEvent do all this? It would avoid having two copies of the code. You'd have to pass it the ClipboardEventInit&.

@@ +100,5 @@
> +    if (event) {
> +      // Always create a clipboardData for the copy event. If this is changed to
> +      // support other types of events, make sure that read/write privileges are
> +      // checked properly within nsDOMDataTransfer.
> +      // If you change this, change also InitFromCtor!

Same here.

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

hmm, I guess it could. ClipboardEvent is a bit unusual

Comment 4

[Olli Pettay [:smaug][[e-mail]]]

Except that I want to have the current Init*Event for C++

Comment 5

[Olli Pettay [:smaug][[e-mail]]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/54bb25670a97

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/54bb25670a97