855524 - [B2G][Browser][l10n] Parts of the Browser app are not fully localized.

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Browser, defect)

Description

[Jeni]

Attachment: picture of issue

Description:
Portions of the Browser are not fully localized 

Repro Steps:
1) Updated to Unagi Build ID: 20130322070203
2) Tap on Browser
3) Tap on URL bar
4) View what is listed below

Actual:
Browser is not fully localized

Expected:
Browser is localized for language device is set to

Environmental  Variables:
Kernel Date: Dec 5
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18_v1_0_1/rev/4931ec89ebbe
Gaia: 85fd164691bb852f1cfaf82405df4380629ced6e

Notes:
Repro frequency: 3/3 100%
See attached screenshot for more info.

Languages affected: 
Spanish, Cestina, Deutsch, Hrvatski, Magyar, Polski, Postugues (do Brasil), Romana
Awesome bar information is not translated
Browser settings are not translated

Comment 1

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

regression?  Seems like there's a top-sites-tab that's not translated.

Comment 2

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

I don't see this issue in :
Gecko  http://hg.mozilla.org/releases/mozilla-b2g18_v1_0_1/rev/c516d7e67150
Gaia   d40dcdd112f12e2a5a0d1de46451670918fd4369
BuildID 20130328070202
Version 18.0

I do see this issue in :
Gecko  http://hg.mozilla.org/releases/mozilla-b2g18/rev/879324d41588
Gaia   e7e7c1a473b4069544f2dad779b1c9b1bab91663
BuildID 20130327070202
Version 18.0

Comment 3

[Jeni]

Attachment: Another screenshot of issue- browser settings not translated

Comment 4

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Spoke with Jeni.  Turns out she's on the ril build and I am using the mozril version.

Ril build uses an older gaia commit:
commit 85fd164691bb852f1cfaf82405df4380629ced6e
Author: Julien Wajsberg <[e-mail]>
Date:   Thu Mar 21 16:40:03 2013 +0100

We'll have to see about getting the ril build with the latest gaia and seeing if that fixes the issue.  Not sure what's going on with v1.1

Comment 5

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Still occurs in today's ril.  RIL builds are based off of v1.1 now.

Comment 6

[Axel Hecht [:Pike]]

This bug is very confusing, these strings should show up localized, as they're shared on v1-train and 1.0.1.

Comment 7

[Wayne Chang [:wchang]]

Fred, can you take a first look at this?
Ken, may need someone to help on this too as to why it may be RIL dependent.

Comment 8

[Wayne Chang [:wchang]]

leo+ this first, we should revisit this when root cause is known.

Comment 9

[Wayne Chang [:wchang]]

Arthur, can you take a look at this and see if you can take the bug?

Comment 10

[Staś Małolepszy :stas]

I'm seeing this in 1.0.1 builds as well.  Most of the browser UI is in English if you cold-boot the app.

Nominating for tef.

Comment 11

[Daniel Coloma:dcoloma]

Could this be related to bug 853424?

Comment 12

[Staś Małolepszy :stas]

I thought so as well, and I tried the proposed patch from bug 853424, but the problem persisted.

Comment 13

[Daniel Coloma:dcoloma]

tef+ as this something that must be solved for the launch

Comment 14

[Arthur Chen [:arthurcc][inactive after 6/30]]

Attachment: Link to https://github.com/mozilla-b2g/gaia/pull/9035

The root cause is that the lazy loaded contents are not translated. Ben, please help review the change. Thanks!

Comment 15

[Ben Francis [:benfrancis]]

I asked kaze to provide some input on this patch, please see the pull request.

Comment 16

[Fabien Cazenave [:kaze]]

As I just wrote on the pull request, I’m a bit worried by this patch.

Comment 17

[Arthur Chen [:arthurcc][inactive after 6/30]]

Kaze, your comments have been addressed. Please check the updated patch.

Comment 19

[Fabien Cazenave [:kaze]]

Arthur, your patch makes sense now but I have one last nitpick.

Comment 20

[Fabien Cazenave [:kaze]]

Comment on attachment 734488 [details]
Link to https://github.com/mozilla-b2g/gaia/pull/9035

Arthur, thanks for your fixes. Looks good to me now.

Comment 21

[Ben Francis [:benfrancis]]

Comment on attachment 734488 [details]
Link to https://github.com/mozilla-b2g/gaia/pull/9035

Thanks

Comment 22

[Ben Francis [:benfrancis]]

Merged into master https://github.com/mozilla-b2g/gaia/commit/2d48fb6a0d209e39907419762d51b4f4eece7113

Requires uplift to v1.0.1 and v1-train.

Comment 23

[John Ford [:jhford] CET/CEST Berlin Time]

Uplifted commit 2d48fb6a0d209e39907419762d51b4f4eece7113 as:
v1-train: abfcc44aa22d1ba446649471351cda7a0d6ae662
v1.0.1: 63890fe9845c13613e9de6017f742a28ea4ee24d

Comment 25

[Delphine Lebédel [:delphine - OOO]]

Verified fixed on master, v1-train and v1.0.1

Comment 26

[John Hammink]

No longer blocks on khepera_43772 for IOT in Chile.