855586 - Patch in bug 824642 has wrong logic

Status: RESOLVED FIXED

(Core :: Graphics: Layers, defect)

Description

[Oleg Romashin (:romaxa)]

Sounds like I managed to make mistake in patch 
https://bugzilla.mozilla.org/attachment.cgi?id=703782&action=edit

+  return mOffscreenFormat != gfxASurface::ImageFormatUnknown ?
+    gfxPlatform::GetPlatform()->GetOffscreenFormat() :
+    mOffscreenFormat;

should be ==, so we use platform format when mOffscreenFormat is unknown (not set)
hrm...

Comment 1

[Oleg Romashin (:romaxa)]

Attachment: make offscreen format correction correct

Comment 2

[Milan Sreckovic [:milan] (needinfo for best results)]

Comment on attachment 730502 [details] [diff] [review]
make offscreen format correction correct

Joe is on PTO for a couple of weeks, let's see if we can take care of this sooner and have it get in before 22 goes to Aurora.

Comment 3

[Nicolas Silva [:nical]]

Comment on attachment 730502 [details] [diff] [review]
make offscreen format correction correct

Review of attachment 730502 [details] [diff] [review]:
-----------------------------------------------------------------

I think this patch is straight-forward and simple enough that it doesn't need Jeff's review (which would mean wait until Monday) to complement mine + Milan's feedback+
You should land it now.

Comment 4

[Milan Sreckovic [:milan] (needinfo for best results)]

Works for me.

Comment 5

[Oleg Romashin (:romaxa)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d61461019eba

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/d61461019eba

Comment 7

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 730502 [details] [diff] [review]
make offscreen format correction correct

Review of attachment 730502 [details] [diff] [review]:
-----------------------------------------------------------------

just to be thorough