If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Patch in bug 824642 has wrong logic

RESOLVED FIXED in mozilla22

Status

()

Core
Graphics: Layers
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: romaxa, Assigned: romaxa)

Tracking

unspecified
mozilla22
ARM
Linux
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
Sounds like I managed to make mistake in patch 
https://bugzilla.mozilla.org/attachment.cgi?id=703782&action=edit

+  return mOffscreenFormat != gfxASurface::ImageFormatUnknown ?
+    gfxPlatform::GetPlatform()->GetOffscreenFormat() :
+    mOffscreenFormat;

should be ==, so we use platform format when mOffscreenFormat is unknown (not set)
hrm...
(Assignee)

Comment 1

5 years ago
Created attachment 730502 [details] [diff] [review]
make offscreen format correction correct
Assignee: nobody → romaxa
Status: NEW → ASSIGNED
Attachment #730502 - Flags: review?(joe)
Comment on attachment 730502 [details] [diff] [review]
make offscreen format correction correct

Joe is on PTO for a couple of weeks, let's see if we can take care of this sooner and have it get in before 22 goes to Aurora.
Attachment #730502 - Flags: review?(nical.bugzilla)
Attachment #730502 - Flags: review?(joe)
Attachment #730502 - Flags: review?(jmuizelaar)
Attachment #730502 - Flags: feedback+
Comment on attachment 730502 [details] [diff] [review]
make offscreen format correction correct

Review of attachment 730502 [details] [diff] [review]:
-----------------------------------------------------------------

I think this patch is straight-forward and simple enough that it doesn't need Jeff's review (which would mean wait until Monday) to complement mine + Milan's feedback+
You should land it now.
Attachment #730502 - Flags: review?(nical.bugzilla) → review+
Works for me.
(Assignee)

Comment 5

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/d61461019eba
https://hg.mozilla.org/mozilla-central/rev/d61461019eba
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla22
Comment on attachment 730502 [details] [diff] [review]
make offscreen format correction correct

Review of attachment 730502 [details] [diff] [review]:
-----------------------------------------------------------------

just to be thorough
Attachment #730502 - Flags: review?(jmuizelaar) → review+
You need to log in before you can comment on or make changes to this bug.