Closed Bug 855595 Opened 8 years ago Closed 8 years ago

Fix signalling unittest regression from bug 839650

Categories

(Core :: WebRTC: Networking, defect, P1)

Product:
Core
Component:
WebRTC: Networking
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla22

People

(Reporter: jesup, Assigned: jesup)

References

Details

(Keywords: regression, Whiteboard: [webrtc][blocking-webrtc+][qa-])

Attachments

(1 file)

Add Listener as well as track for unittests. Also clean up warnings
3.39 KB, patch
ekr
: review+
Details | Diff | Splinter Review 
For FakeMediaStreams, the patch in bug 839650 didn't add the Listener as well as the track.  This causes 5 or so failures in signaling_unittest
Depends on: 839650
Attachment #730536 - Flags: review?(ekr)
https://tbpl.mozilla.org/?tree=Try&rev=dc16b8d69a39

Try with signaling and mediaconduit tests enabled
Comment on attachment 730536 [details] [diff] [review]
Add Listener as well as track for unittests.  Also clean up warnings

Review of attachment 730536 [details] [diff] [review]:
-----------------------------------------------------------------

lgtm
Attachment #730536 - Flags: review?(ekr) → review+
https://hg.mozilla.org/mozilla-central/rev/231da3d51bf9
Status: NEW → RESOLVED
Closed: 8 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Whiteboard: [webrtc][blocking-webrtc+] → [webrtc][blocking-webrtc+][qa-]
You need to log in before you can comment on or make changes to this bug.