Closed
Bug 855595
Opened 12 years ago
Closed 12 years ago
Fix signalling unittest regression from bug 839650
Categories
(Core :: WebRTC: Networking, defect, P1)
Core
WebRTC: Networking
Tracking
()
RESOLVED
FIXED
mozilla22
People
(Reporter: jesup, Assigned: jesup)
References
Details
(Keywords: regression, Whiteboard: [webrtc][blocking-webrtc+][qa-])
Attachments
(1 file)
3.39 KB,
patch
|
ekr
:
review+
|
Details | Diff | Splinter Review |
For FakeMediaStreams, the patch in bug 839650 didn't add the Listener as well as the track. This causes 5 or so failures in signaling_unittest
Assignee | ||
Comment 1•12 years ago
|
||
Assignee | ||
Updated•12 years ago
|
Attachment #730536 -
Flags: review?(ekr)
Assignee | ||
Comment 2•12 years ago
|
||
https://tbpl.mozilla.org/?tree=Try&rev=dc16b8d69a39
Try with signaling and mediaconduit tests enabled
Comment 3•12 years ago
|
||
Comment on attachment 730536 [details] [diff] [review]
Add Listener as well as track for unittests. Also clean up warnings
Review of attachment 730536 [details] [diff] [review]:
-----------------------------------------------------------------
lgtm
Attachment #730536 -
Flags: review?(ekr) → review+
Assignee | ||
Comment 4•12 years ago
|
||
Target Milestone: --- → mozilla22
Comment 5•12 years ago
|
||
Status: NEW → RESOLVED
Closed: 12 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Updated•12 years ago
|
Whiteboard: [webrtc][blocking-webrtc+] → [webrtc][blocking-webrtc+][qa-]
You need to log in
before you can comment on or make changes to this bug.
Description
•