855643 - [B2G] RIL: can't get correct selectionMode at the first time querying mobileConnection.networkSelectionMode

Status: VERIFIED FIXED

(Firefox OS Graveyard :: General, defect)

Description

[Evelyn Hung]

When Settings app launched, the first query of `mobileConnection.networkSelectionMode` always get 'null', but it did changed to 'manual' if we successfully switch to another operator network.

nominate it as tef+ since it blocks bug 852038 which is a tef+

Comment 1

[Hsin-Yi Tsai (she/her) [:hsinyi]]

The cause of this issue is that RadioInterfaceLayer only send |RIL:NetworkSelectionModeChanged| once if user doesn't ask to change the selection mode. So, when settings app is up, RILContentHelper of that process would have no chance to get the selectionMode. The solution would be that RILContentHelper actively updates the mode in its constructor. Patch ongoing.

Comment 2

[Hsin-Yi Tsai (she/her) [:hsinyi]]

Oops, sorry, I didn't mean to innominate tef :(

Comment 3

[Hsin-Yi Tsai (she/her) [:hsinyi]]

Attachment: patch

Please see my comment#1.

Comment 4

[Hsin-Yi Tsai (she/her) [:hsinyi]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/75759f66b716

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/75759f66b716

Comment 6

[Ryan VanderMeulen [:RyanVM]]

This is going to need a b2g18-specific patch or some uplift approval for dependent bugs.

Comment 7

[Hsin-Yi Tsai (she/her) [:hsinyi]]

(In reply to Ryan VanderMeulen [:RyanVM] from comment #6)
> This is going to need a b2g18-specific patch or some uplift approval for
> dependent bugs.

The patch is on the way. Thanks, RyanVM!

Comment 8

[Hsin-Yi Tsai (she/her) [:hsinyi]]

Attachment: Patch for b2g-18

Comment 9

[Hsin-Yi Tsai (she/her) [:hsinyi]]

b2g-18 patch checkin-needed, thanks.

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-b2g18/rev/6dfeb2060033
https://hg.mozilla.org/releases/mozilla-b2g18_v1_0_1/rev/d3954ec849a1

Comment 11

[Alex Keybl [:akeybl]]

Requesting a backout in email, given the fact that the commercial RIL may break from this change.

Comment 12

[Ryan VanderMeulen [:RyanVM]]

Backed out.
https://hg.mozilla.org/releases/mozilla-b2g18/rev/0b8726395712
https://hg.mozilla.org/releases/mozilla-b2g18_v1_0_1/rev/270a2e6516ce

Comment 13

[Anshul]

We have finished implementing this functionality in commercial RIL. However due to some technical issues we are unable to make an AU release tonight. The AU should be available tomorrow.

Comment 14

[Michael Vines [:m1] [:evilmachines]]

Hey John, can this bug please be bumped to the front of your uplift queue?

Comment 15

[John Ford [:jhford] CET/CEST Berlin Time]

https://hg.mozilla.org/releases/mozilla-b2g18/rev/056b4044f178

Waiting on v1.0.1 to finish updating locally

Comment 16

[John Ford [:jhford] CET/CEST Berlin Time]

https://hg.mozilla.org/releases/mozilla-b2g18_v1_0_1/rev/c0933e992d78

Comment 17

[amiller]

This issue appears fixed on the Unagi build ID: 20130410070209
Kernel Date: Dec 5
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/423f7851bdb5
Gaia: c614b3f3c956dc1e1adf93cf4cf41511ce75de80

also, issue appears fixed on  Unagi build ID: 20130410070204
Kernel Date: Dec 5
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18_v1_0_1/rev/935ff9a97f7b
Gaia: aff876b051c51d091cecf322b90c4f0093281b5e

When Settings app launched, the first query displays properly.