If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Fix compiler warnings in NSS 3.15

RESOLVED FIXED in 3.15

Status

NSS
Libraries
P2
normal
RESOLVED FIXED
5 years ago
4 years ago

People

(Reporter: Wan-Teh Chang, Assigned: Wan-Teh Chang)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(3 attachments)

(Assignee)

Description

5 years ago
Created attachment 730847 [details] [diff] [review]
Fix gcc warnings in lib/certdb/crl.c and lib/certhigh/ocspsig.c

I will use this bug report for miscellaneous compiler warnings
that don't warrant their own bug reports.

Notes on the first patch:
1. SECSuccess and secCertTimeValid have the same value (0), so
this is a benign type mismatch.
2. The |data| member of a SECItem is an unsigned char * pointer,
so it can't point to a char without a cast.
Attachment #730847 - Flags: review?(ryan.sleevi)

Updated

5 years ago
Attachment #730847 - Flags: review?(ryan.sleevi) → review+
(Assignee)

Comment 1

5 years ago
Comment on attachment 730847 [details] [diff] [review]
Fix gcc warnings in lib/certdb/crl.c and lib/certhigh/ocspsig.c

https://hg.mozilla.org/projects/nss/rev/0b3f656c6a33
Attachment #730847 - Flags: checked-in+
(Assignee)

Comment 2

4 years ago
Created attachment 745443 [details] [diff] [review]
Fix compiler warnings in ssl3ext.c

1. PR_CallOnce() returns PRStatus, so its return value should be compared
with PR_SUCCESS.

2. The |len| variable in ssl3_ServerHandleStatusRequestXtn is set but
unused.
Attachment #745443 - Flags: review?(bsmith)
Attachment #745443 - Flags: review?(bsmith) → review+
(Assignee)

Comment 3

4 years ago
Comment on attachment 745443 [details] [diff] [review]
Fix compiler warnings in ssl3ext.c

Review of attachment 745443 [details] [diff] [review]:
-----------------------------------------------------------------

https://hg.mozilla.org/projects/nss/rev/c8f88da715b2
Attachment #745443 - Flags: checked-in+
(Assignee)

Comment 4

4 years ago
Created attachment 746567 [details] [diff] [review]
Remove unused $(SECURITY_FLAG) from nss/lib/dbm/src/config.mk

This MXR query shows SECURITY_FLAG is referenced but never set:
http://mxr.mozilla.org/mozilla-central/search?string=SECURITY_FLAG

CVS history shows the $(SECURITY_FLAG) reference has been there
since day one (as early as year 1999), so it's not something that
we or Mozilla added recently to control how DBM is built.
Attachment #746567 - Flags: review?(emaldona)

Updated

4 years ago
Attachment #746567 - Flags: review?(emaldona) → review+
(Assignee)

Comment 5

4 years ago
Comment on attachment 746567 [details] [diff] [review]
Remove unused $(SECURITY_FLAG) from nss/lib/dbm/src/config.mk

Review of attachment 746567 [details] [diff] [review]:
-----------------------------------------------------------------

https://hg.mozilla.org/projects/nss/rev/a597c2b94fc2
Attachment #746567 - Flags: checked-in+
(Assignee)

Updated

4 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.