855917 - Minor nsAbsoluteContainingBlock code cleanup

Status: RESOLVED FIXED

(Core :: Layout: Block and Inline, defect)

Comment 1

[Mats Palmgren (inactive)]

Attachment: fix

Remove unnecessary includes, convert comment to doc-comment style, etc

Comment 2

[Daniel Holbert [:dholbert]]

Comment on attachment 731000 [details] [diff] [review]
fix

>+++ b/layout/generic/nsAbsoluteContainingBlock.h
[...]
>+    MOZ_ASSERT(mChildListID == nsIFrame::kAbsoluteList ||
>+               mChildListID == nsIFrame::kFixedList,
>+               "should either represent position:fixed or absolute content");
>   }
> 
> #ifdef DEBUG
>   ChildListID GetChildListID() const { return mChildListID; }
> #endif

While you're here, it might be worth getting rid of GetChildListID() entirely, too.  It's only ever called from inside this class (and only in assertions), so we can replace all its invocations with just "mChildListID".  No need for a getter.

(Might be worth separating into a second patch on this bug. rs=me on that patch, if you want to do it.)

The attached patch looks good, regardless -- r=me

Comment 3

[Mats Palmgren (inactive)]

> While you're here, it might be worth getting rid of GetChildListID() entirely, too.

Did so.

I took the liberty of making HasAbsoluteFrames() const too.

https://hg.mozilla.org/integration/mozilla-inbound/rev/17b3ba7a38f2

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/17b3ba7a38f2