855968 - B2G MMS: delivery is not correctly indexed in DB

Status: RESOLVED FIXED

(Core :: DOM: Device Interfaces, defect)

Description

[Gene Lian (I already quit Mozilla)]

Since the delivery is now determined by the caller site, which means the MMS' delivery can be either of DELIVERY_RECEIVED or DELIVERY_NOT_DOWNLOADED, the delivery index cannot be hard-coded like SMS. This would fail the delivery filtering.

Comment 1

[Gene Lian (I already quit Mozilla)]

Attachment: Patch

Comment 2

[Chia-hung Tai [:ctai :ctai_mozilla :cht]]

Comment on attachment 731044 [details] [diff] [review]
Patch

Review of attachment 731044 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to, thanks.

Comment 3

[Chia-hung Tai [:ctai :ctai_mozilla :cht]]

(In reply to Chia-hung Tai [:ctai :ctai_mozilla :cht] from comment #2)
> Comment on attachment 731044 [details] [diff] [review]
> Patch
> 
> Review of attachment 731044 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Looks good to, thanks.
Looks good to me, thanks.

Comment 4

[Gene Lian (I already quit Mozilla)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/ac442ffde0bc

Comment 5

[Gene Lian (I already quit Mozilla)]

Comment on attachment 731044 [details] [diff] [review]
Patch

[Approval Request Comment]
Bug caused by (feature/regressing bug #): not yet reported as a bug but it's actually a follow-up correctness for Bug 845643.
User impact if declined: without the patch, we cannot correctly search the MMS messages with delivery == "not-downloaded".
Testing completed: yes
Risk to taking this patch (and alternatives if risky): absolutely no. This patch only corrects the MMS codes for constructing the delivery index for DB searching. SMS is not affected.
String or UUID changes made by this patch: no

Comment 6

[Joe Cheng [:jcheng] (please needinfo)]

leo+ as this is a part of MMS. No_UPLIFT for now before the whole MMS is completed

Comment 7

[Gene Lian (I already quit Mozilla)]

Comment on attachment 731044 [details] [diff] [review]
Patch

All right... Let's remove approval-mozilla-b2g18 because of NO_UPLIFT and leo+.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/ac442ffde0bc

Comment 9

[Vicamo Yang [:vicamo][:vyang]]

Uplift WIP: https://github.com/vicamo/b2g_mozilla-central/tree/bugzilla/838467/b2g18 , verifying.

Comment 10

[Vicamo Yang [:vicamo][:vyang]]

https://hg.mozilla.org/releases/mozilla-b2g18/rev/23f909c9bff2