855981 - [B2G] sync hwcomposer header between Android HAL and B2G gonk

Status: RESOLVED FIXED

(Firefox OS Graveyard :: GonkIntegration, defect)

Description

[Peter Chang[:pchang]]

Got crash with the following configuration on ZTE open.
+pref("layers.composer2d.enabled", true);

[crash stack]
Crash reason:  SIGSEGV
Crash address: 0x129

Thread 20 (crashed)
 0  hwcomposer.msm7627a.so!getYUVBufferCount [hwcomposer.cpp : 918 + 0x0]
     r4 = 0x00000004    r5 = 0x00000001    r6 = 0x47c6db50    r7 = 0x48094340
     r8 = 0x480a9280    r9 = 0x49ea93e0   r10 = 0x000001e0    fp = 0x000001e0
     sp = 0x46660a84    lr = 0x427c3bbf    pc = 0x427c2f1a
    Found by: given as instruction pointer in context
 1  hwcomposer.msm7627a.so!hwc_set [hwcomposer.cpp : 1624 + 0x5]
     sp = 0x46660a90    pc = 0x427c3bbf
    Found by: stack scanning

Comment 1

[Peter Chang[:pchang]]

Attachment: sync hwcomposer header

There was a missing filed (alpha) in struct hwc_layer and caused crash during parsing hwc_layer list.

Attached patch to sync hwcomposer header between Android HAL and B2G gonk.

Comment 2

[Michael Wu [:mwu]]

Comment on attachment 731073 [details] [diff] [review]
sync hwcomposer header

If you look at the patches in https://www.codeaurora.org/gitweb/quic/lf/?p=build.git;a=tree;f=patch/ics_strawberry;h=790a1867fd00a56d8d8fad07d8009e631c312b75;hb=refs/heads/v1 , there are patches which remove the alpha field. These patches are used by downstream vendors.

Comment 3

[Diego Wilson [:diego]]

mwu's correct. More details about why in bug 800056

Comment 4

[Peter Chang[:pchang]]

Looks like there are some related patches need to be applied first to check HWC function.
So close this case.