Hook up build symbols creation to main Makefile

RESOLVED FIXED in 3.2

Status

Calendar
Build Config
RESOLVED FIXED
5 years ago
4 years ago

People

(Reporter: Fallen, Assigned: Fallen)

Tracking

unspecified

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

5 years ago
Created attachment 731173 [details] [diff] [review]
Fix - v1

The buildsymbols target is currently called by Lightning build automation. I'd like to hook this up to the main target, so it will also be processed by the Thunderbird build infrastructure.

This should take care, and also simplifies the symbols generation code.
Attachment #731173 - Flags: review?(mbanner)
Comment on attachment 731173 [details] [diff] [review]
Fix - v1

Review of attachment 731173 [details] [diff] [review]:
-----------------------------------------------------------------

Looks fine to me.
Attachment #731173 - Flags: review?(mbanner) → review+
(Assignee)

Comment 2

4 years ago
Pushed to comm-central changeset d960cb7324e3
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 3.2
Philipp: I tried to fix a build bustage related to the patch for this issue, see https://hg.mozilla.org/comm-central/rev/a3a8a9b5cd96.
I think the bustage-fix is still broken, you're calling make -C directly instead of $(MAKE) -C.

Pushed to try: <https://tbpl.mozilla.org/?tree=Thunderbird-Try&rev=4b18a2806ccd>.
(Assignee)

Comment 5

4 years ago
I've backed the patch out for now. With Joshua's try builds (thanks!) it still fails and it seems to be choking on the call to symbolstore.py. Comparing with the way Thunderbird calls this, I don't see much difference in the calls. Comparing with what instantbird recently did in comm-central changeset f8112386067e, it seems we might need to add $(topsrcdir) and $(topsrcdir)/mozilla as source directories?

On the other hand, looking at another build without this patch, it seems to me that lightning symbols are already included. As soon as I remember where the thunderbird symbols are kept I will try to verify that.


Backout in changeset:
https://hg.mozilla.org/comm-central/rev/875fa6992fbd
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
(Assignee)

Comment 6

4 years ago
Created attachment 8385175 [details] [diff] [review]
Fix - v2

I've verified that:

thunderbird-30.0a1-WINNT-20140303030204-x86-symbols.txt
thunderbird-30.0a1-Linux-20140303030204-x86-symbols.txt 
thunderbird-30.0a1-Darwin-20140303030204-x86-macosx64-symbols.txt

all have (lib)calbasecomps.dll/so/dylib.

Mark, is my assumption correct that this means I can just remove our symbol code and rely on the Thunderbird symbols?
Attachment #731173 - Attachment is obsolete: true
Attachment #8385175 - Flags: review?(standard8)
Comment on attachment 8385175 [details] [diff] [review]
Fix - v2

Review of attachment 8385175 [details] [diff] [review]:
-----------------------------------------------------------------

I'd expect the symbols to do the right thing from what I've heard in the past. So this is probably fine.
Attachment #8385175 - Flags: review?(standard8) → review+
(Assignee)

Comment 8

4 years ago
Pushed to comm-central changeset 27ef044cfd3a
Status: REOPENED → RESOLVED
Last Resolved: 4 years ago4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.