856158 - Flag and requestee shortcut for quicksearch breaks search terms containing ?

Status: RESOLVED FIXED

(Bugzilla :: Query/Bug List, defect)

Description

[David Lawrence [:dkl]]

When http://bzr.mozilla.org/bugzilla/trunk/revision/6742 was introduced it no longer allows different search terms to include '?' otherwise they will be treated as flags which they are not.

For example the following quicksearch no longer works after upograding to 4.2:

ALL classification:"Client Software" OR classification:"Components" AND summary:"ABORT: Channel completed connect, but not connecting?: 'aChannel->mConnecting == CONNECTING_IN_PROGRESS'" OR comment:"ABORT: Channel completed connect, but not connecting?: 'aChannel->mConnecting == CONNECTING_IN_PROGRESS'"

The above search generates improperly:

Classification: Client Software
Classification: Components
Flags: summary:"ABORT: Channel completed connect, but not connecting?
Flag Requestee: : 'aChannel->mConnecting == CONNECTING_IN_PROGRESS'"
Flags: comment:"ABORT: Channel completed connect, but not connecting?
Flag Requestee: : 'aChannel->mConnecting == CONNECTING_IN_PROGRESS'"

Offending code:

sub _handle_field_names {
    my ($or_operand, $negate, $unknownFields, $ambiguous_fields) = @_;

    # Flag and requestee shortcut
    if ($or_operand =~ /^(?:flag:)?([^\?]+\?)([^\?]*)$/) {
        addChart('flagtypes.name', 'substring', $1, $negate);
        $chart++; $and = $or = 0; # Next chart for boolean AND
        addChart('requestees.login_name', 'substring', $2, $negate);
        return 1;
    }

Will need to see how to rework the regexp to not treat as a flag if a colon ':' comes before the '?' maybe if we do not think flagnames will ever have a ':' in it which we don't enforce.

Thoughts?
dkl

Comment 1

[Frédéric Buclin]

(In reply to David Lawrence [:dkl] from comment #0)
> When http://bzr.mozilla.org/bugzilla/trunk/revision/6742 was introduced it
> no longer allows different search terms to include '?' otherwise they will
> be treated as flags which they are not.

This patch is not the culprit. It landed in 3.6, see bug 490551, and neither 3.6 nor 4.0 are affected by this bug. So this is a regression in 4.2. I will investigate.

Comment 2

[Frédéric Buclin]

The "culprit" is bug 554819 where we no longer call url_quote() via the buggy splitString() subroutine. So in 4.0 and older, "a?b" was replaced by a%3Fb and so didn't trigger the flag+requestee shortcuts. In 4.2, "a?b" is not encoded and trigger the flag+requestee shortcuts. The tricky part is that flag names such as |a:v"b:c?d| are legal, and so could totally confuse the parser. But that's the kind of edge cases which I don't really care about.

Comment 3

[Frédéric Buclin]

Attachment: patch, v1

Comment 4

[:glob ✱]

this conflicts with my work on bug 828344, so i'll hold off on doing this review until that has been committed.

Comment 5

[Jesse Ruderman]

I hit this too.

https://bugzilla.mozilla.org/buglist.cgi?quicksearch=summary%3A%22No%20next%20sibling!%3F!%20This%20could%20mean%20deadlock!%22

Comment 6

[Frédéric Buclin]

Bugzilla 4.2 is now restricted to security fixes only.

Comment 7

[Frédéric Buclin]

Attachment: patch, v1.1

I fixed bitrot.

Comment 8

[:glob ✱]

Comment on attachment 758533 [details] [diff] [review]
patch, v1.1

r=glob

>+        $chart++; $and = $or = 0;

break this into two lines before committing.

Comment 9

[Frédéric Buclin]

Committing to: bzr+ssh://[e-mail]/bugzilla/trunk/
modified Bugzilla/Search/Quicksearch.pm
Committed revision 8636.

Committing to: bzr+ssh://[e-mail]/bugzilla/4.4/
modified Bugzilla/Search/Quicksearch.pm
Committed revision 8568.