856170 - Reduce number of queries executed during FHR initialization

Status: RESOLVED WONTFIX

(Firefox Health Report Graveyard :: Client: Desktop, defect, P2)

Description

[Richard Newman [:rnewman]]

On a first run we execute 168 queries. I think we can do better than that.

Comment 1

[Richard Newman [:rnewman]]

Attachment: Part 1. v1

This alone knocks 5% off our test execution times for services/metrics, and we don't even use IN (?…) to limit our fetch.

Comment 2

[Gregory Szorc [:gps]]

Comment on attachment 731913 [details] [diff] [review]
Part 1. v1

Review of attachment 731913 [details] [diff] [review]:
-----------------------------------------------------------------

Please re-request review once Sqlite.jsm API has been agreed upon. If the API doesn't change, I'll rubber stamp r+ (since there is nothing holding me back now except for API design questions).

::: services/metrics/storage.jsm
@@ +1191,5 @@
>        }
>  
>        // Don't perform DB transaction unless there is work to do.
> +      if (missingTypes.size) {
> +        let params = function params(array) {

Nit: I don't like names that conflict with built-ins, even if the case is different.

Comment 3

[Georg Fritzsche [:gfritzsche]]

FHR is going away per bug 1209088, wontfix.