Reduce number of queries executed during FHR initialization

RESOLVED WONTFIX

Status

P2
normal
RESOLVED WONTFIX
6 years ago
3 years ago

People

(Reporter: rnewman, Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

6 years ago
On a first run we execute 168 queries. I think we can do better than that.
(Reporter)

Updated

6 years ago
Assignee: nobody → rnewman
Status: NEW → ASSIGNED
Priority: -- → P2
(Reporter)

Updated

6 years ago
Depends on: 833965
(Reporter)

Comment 1

5 years ago
Created attachment 731913 [details] [diff] [review]
Part 1. v1

This alone knocks 5% off our test execution times for services/metrics, and we don't even use IN (?…) to limit our fetch.
Attachment #731913 - Flags: review?(gps)

Comment 2

5 years ago
Comment on attachment 731913 [details] [diff] [review]
Part 1. v1

Review of attachment 731913 [details] [diff] [review]:
-----------------------------------------------------------------

Please re-request review once Sqlite.jsm API has been agreed upon. If the API doesn't change, I'll rubber stamp r+ (since there is nothing holding me back now except for API design questions).

::: services/metrics/storage.jsm
@@ +1191,5 @@
>        }
>  
>        // Don't perform DB transaction unless there is work to do.
> +      if (missingTypes.size) {
> +        let params = function params(array) {

Nit: I don't like names that conflict with built-ins, even if the case is different.
Attachment #731913 - Flags: review?(gps)

Updated

5 years ago
Component: Metrics and Firefox Health Report → Client: Desktop
Product: Mozilla Services → Firefox Health Report
(Reporter)

Updated

5 years ago
Assignee: rnewman → nobody
FHR is going away per bug 1209088, wontfix.
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.