Fix compiler warnings and clean up code in NSPR 4.10

RESOLVED FIXED in 4.10

Status

NSPR
NSPR
P2
minor
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: Wan-Teh Chang, Assigned: Wan-Teh Chang)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
Created attachment 731323 [details] [diff] [review]
Pass lpPreviousCount=NULL to ReleaseSemaphore. prlong.c only needs to include prlong.h.

I will use this bug report for compiler warnings and minor
issues that don't warrant their own bug reports.

In the first patch, I pass NULL as the third argument to
ReleaseSemaphore (this is allowed, see the lpPreviousCount in
http://msdn.microsoft.com/en-us/library/windows/desktop/ms685071(v=vs.85).aspx )
and include "prlong.h" instead of "primpl.h", which contains
a lot of unnecessary internal declarations.
Attachment #731323 - Flags: review?(kaie)

Updated

5 years ago
Attachment #731323 - Flags: review?(kaie) → review+
(Assignee)

Comment 1

5 years ago
Comment on attachment 731323 [details] [diff] [review]
Pass lpPreviousCount=NULL to ReleaseSemaphore. prlong.c only needs to include prlong.h.

Review of attachment 731323 [details] [diff] [review]:
-----------------------------------------------------------------

https://hg.mozilla.org/projects/nspr/rev/b211946d0f56
https://hg.mozilla.org/projects/nspr/rev/e2c212c02db7
Attachment #731323 - Flags: checked-in+
(Assignee)

Updated

5 years ago
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Priority: -- → P2
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.