856203 - [FHR] The y-axis label is missing from the Startup Time by Day graph

Status: VERIFIED FIXED

(Firefox Health Report Graveyard :: Web: Health Report, defect)

Description

[Larissa Co [:lco]]

Attachment: 2013-03-29 FHR graph

The y-axis should say "Time (in seconds)"

Note: if seconds is too long, we can switch to milliseconds, or whatever the appropriate scale is.

Comment 1

["Saptarshi Guha[:joy]"]

I'd keep to this seconds, since that is probably the easiest for people to consume.

'All' needs an X-axis scale. Dates (like avg )

I'd keep the Y-axis positive. Having looked at the data, 90% of the firstpaint times 0.009 seconds to 10 seconds.

Of course for a given installation, the scale range might be different, but this is observed from Nightly 22 data.

so i'd recommend we keep to seconds with tick marks at every 0.1 second

Comment 2

[Schalk Neethling [:espressive]]

So, this was one of my questions, are we plotting seconds or milliseconds? We get milliseconds back.

Comment 3

[Schalk Neethling [:espressive]]

seconds it is

Comment 4

["Saptarshi Guha[:joy]"]

Yes, seconds, and do have minor tick marks. That is
major tick marks at seconds (1sec,2sec,...) and minor tick marks at every 0.2 seconds (so 4 in between every second) i.e. 1 sec(major), 4 ticks (at 1.2,1.4,1.6,1.8) and then major. The minor ticks don't have to be labelled.
Also, the yscale should start at 0, not negative.
Thanks

Comment 5

[Schalk Neethling [:espressive]]

(In reply to Saptarshi Guha from comment #4)
> Yes, seconds, and do have minor tick marks. That is
> major tick marks at seconds (1sec,2sec,...) and minor tick marks at every
> 0.2 seconds (so 4 in between every second) i.e. 1 sec(major), 4 ticks (at
> 1.2,1.4,1.6,1.8) and then major. The minor ticks don't have to be labelled.
> Also, the yscale should start at 0, not negative.
> Thanks

I have changed the display unit to now be seconds. In terms of major and minor ticks, the current library we use does not seem to support it 'out-of-the-box' but, I am looking into a way to add support for this.

Comment 6

[Schalk Neethling [:espressive]]

Two pull requests sent for this bug:
https://github.com/mozilla/fhr-jelly/pull/38
https://github.com/mozilla/fhr-jelly/pull/39

Comment 7

[Laura Thomson :laura]

r+, merged

Comment 8

[Pascal Chevrel (relman team) -> :pascalc]

That one broke string freeze, this string was not given for translation

Comment 9

[Pascal Chevrel (relman team) -> :pascalc]

Ok, string added for translation, I am pinging people to get the string maybe translated today

Comment 10

[Matt Brandt [:mbrandt]]

Attachment: qa - verified on dev

QA verified on dev and prod - the y-axis label is present for both the 'Average' and 'All' plots.