Closed Bug 856349 Opened 7 years ago Closed 7 years ago

remove useless SHORT_LIBNAME assignments

Categories

(Firefox Build System :: General, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
mozilla23

People

(Reporter: tbsaunde, Assigned: tbsaunde)

Details

Attachments

(1 file, 1 obsolete file)

config.mk has
if LIBXUL_BIRARY
SHORT_LIBNAME =
endif

the only thing it appears to be actually used for is the library name on os2 for shared libs.

so it seems pretty safe to remove all the assignments in makefiles for stuff that goes in libxul.
also prevent people from defining it when LIBXUL_LIBRARY is also defined

https://tbpl.mozilla.org/?tree=Try&rev=9d1ac11fda88
Attachment #731538 - Flags: review?(mh+mozilla)
Comment on attachment 731538 [details] [diff] [review]
bug 856349 - remove useless SHORT_LIBNAME assignments

curse you check-sync-dirs pushed https://tbpl.mozilla.org/?tree=Try&rev=ab7d831c2185
Attachment #731538 - Attachment is obsolete: true
Attachment #731538 - Flags: review?(mh+mozilla)
Attached patch patchSplinter Review
Assignee: nobody → trev.saunders
Status: NEW → ASSIGNED
Attachment #731736 - Flags: review?(mh+mozilla)
Comment on attachment 731736 [details] [diff] [review]
patch

Review of attachment 731736 [details] [diff] [review]:
-----------------------------------------------------------------

::: config/config.mk
@@ +246,5 @@
>  endif
>  endif
>  FORCE_STATIC_LIB=1
> +ifneq ($(SHORT_LIBNAME),)
> +$(error make file is in libxul but  gives SHORT_LIBNAME as $(SHORT_LIBNAME))

SHORT_LIBNAME is not compatible with LIBXUL_LIBRARY.
Attachment #731736 - Flags: review?(mh+mozilla) → review+
(In reply to Mike Hommey [:glandium] from comment #4)
> Comment on attachment 731736 [details] [diff] [review]
> patch
> 
> Review of attachment 731736 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: config/config.mk
> @@ +246,5 @@
> >  endif
> >  endif
> >  FORCE_STATIC_LIB=1
> > +ifneq ($(SHORT_LIBNAME),)
> > +$(error make file is in libxul but  gives SHORT_LIBNAME as $(SHORT_LIBNAME))
> 
> SHORT_LIBNAME is not compatible with LIBXUL_LIBRARY.

or "SHORT_LIBNAME is deprecated when used with LIBXUL_LIBRARY" or something along these lines.
This is effectively "drop OS/2 support", which is probably OK because I don't think that port is active anymore.
(In reply to Ted Mielczarek [:ted.mielczarek] from comment #6)
> This is effectively "drop OS/2 support", which is probably OK because I
> don't think that port is active anymore.

no, see comment 1 this patch doesn't change the uses of SHORT_LIBNAME where a shared lib is produced.  Not that I'd object to killing OS2 support.
This caused some needs-clobber bustage on Windows. Pushed an update to CLOBBER for posterity's sake.
https://hg.mozilla.org/integration/mozilla-inbound/rev/107e9db562b3
You appear to have missed xpfe/components/autocomplete/src...
one more to fix c-c :-( sorry!
remote:   https://hg.mozilla.org/mozilla-central/rev/b1fb34b07c17
Pushed by frgrahl@gmx.net:
https://hg.mozilla.org/comm-central/rev/82d7b3962b8e
follow up to fix c-c by removing SHORT_LIBNAME from xpfe/components/autocomplete/src/Makefile.in r=me
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.