Remove Contact types from window

RESOLVED FIXED in mozilla23

Status

()

Core
DOM: Device Interfaces
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: reuben, Assigned: reuben)

Tracking

Trunk
mozilla23
Points:
---
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
As far as I can see, ContactProperties, ContactAddress, ContactField, ContactTelField, ContactFindSortOptions and ContactFindOptions are unnecessarily exposed to the Web.
(Assignee)

Comment 1

5 years ago
Gregor, should those be exposed in |window|?
Flags: needinfo?(anygregor)
(In reply to Reuben Morais [:reuben] from comment #1)
> Gregor, should those be exposed in |window|?

They are basically just types for the API and dictionaries. Since you can just pass any js object into the API we don't have to expose them any more.
Flags: needinfo?(anygregor)
(Assignee)

Comment 3

5 years ago
Created attachment 734157 [details] [diff] [review]
Don't expose ContactProperties types on window
(Assignee)

Comment 4

5 years ago
Comment on attachment 734157 [details] [diff] [review]
Don't expose ContactProperties types on window

Looks green on Try: https://tbpl.mozilla.org/?tree=Try&rev=c753d6b8a5cc
Attachment #734157 - Flags: review?(anygregor)
Attachment #734157 - Flags: review?(anygregor) → review+
I think you have to change the uuid as well.
(Assignee)

Comment 9

5 years ago
Follow-up to fix a UUID mismatch… ಠ_ಠ
https://hg.mozilla.org/integration/mozilla-inbound/rev/59360cb3396f
https://hg.mozilla.org/mozilla-central/rev/ab0974ead030
https://hg.mozilla.org/mozilla-central/rev/59360cb3396f
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla23

Updated

5 years ago
Keywords: dev-doc-needed, site-compat
This won't affect site compatibility as the availability of the API is limited.
Keywords: dev-doc-needed, site-compat
You need to log in before you can comment on or make changes to this bug.