Closed Bug 856358 Opened 8 years ago Closed 8 years ago
Remove Contact types from window
As far as I can see, ContactProperties, ContactAddress, ContactField, ContactTelField, ContactFindSortOptions and ContactFindOptions are unnecessarily exposed to the Web.
Gregor, should those be exposed in |window|?
(In reply to Reuben Morais [:reuben] from comment #1) > Gregor, should those be exposed in |window|? They are basically just types for the API and dictionaries. Since you can just pass any js object into the API we don't have to expose them any more.
Comment on attachment 734157 [details] [diff] [review] Don't expose ContactProperties types on window Looks green on Try: https://tbpl.mozilla.org/?tree=Try&rev=c753d6b8a5cc
Attachment #734157 - Flags: review?(anygregor)
Attachment #734157 - Flags: review?(anygregor) → review+
I think you have to change the uuid as well.
Apparently it needed a clobber, see bug 860894. https://hg.mozilla.org/integration/mozilla-inbound/rev/ab0974ead030
Follow-up to fix a UUID mismatch… ಠ_ಠ https://hg.mozilla.org/integration/mozilla-inbound/rev/59360cb3396f
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla23
This won't affect site compatibility as the availability of the API is limited.
You need to log in before you can comment on or make changes to this bug.