Closed
Bug 856358
Opened 11 years ago
Closed 11 years ago
Remove Contact types from window
Categories
(Core :: DOM: Device Interfaces, defect)
Core
DOM: Device Interfaces
Tracking
()
RESOLVED
FIXED
mozilla23
People
(Reporter: reuben, Assigned: reuben)
Details
Attachments
(1 file)
17.50 KB,
patch
|
gwagner
:
review+
|
Details | Diff | Splinter Review |
As far as I can see, ContactProperties, ContactAddress, ContactField, ContactTelField, ContactFindSortOptions and ContactFindOptions are unnecessarily exposed to the Web.
Assignee | ||
Comment 1•11 years ago
|
||
Gregor, should those be exposed in |window|?
Flags: needinfo?(anygregor)
Comment 2•11 years ago
|
||
(In reply to Reuben Morais [:reuben] from comment #1) > Gregor, should those be exposed in |window|? They are basically just types for the API and dictionaries. Since you can just pass any js object into the API we don't have to expose them any more.
Flags: needinfo?(anygregor)
Assignee | ||
Comment 3•11 years ago
|
||
Assignee | ||
Comment 4•11 years ago
|
||
Comment on attachment 734157 [details] [diff] [review] Don't expose ContactProperties types on window Looks green on Try: https://tbpl.mozilla.org/?tree=Try&rev=c753d6b8a5cc
Attachment #734157 -
Flags: review?(anygregor)
Updated•11 years ago
|
Attachment #734157 -
Flags: review?(anygregor) → review+
Comment 5•11 years ago
|
||
I think you have to change the uuid as well.
Assignee | ||
Comment 6•11 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/5e573a8f7ce1
Comment 7•11 years ago
|
||
Backed out for bustage. https://hg.mozilla.org/integration/mozilla-inbound/rev/e7cb5c6e47f0 https://tbpl.mozilla.org/php/getParsedLog.php?id=21694009&tree=Mozilla-Inbound
Assignee | ||
Comment 8•11 years ago
|
||
Apparently it needed a clobber, see bug 860894. https://hg.mozilla.org/integration/mozilla-inbound/rev/ab0974ead030
Assignee | ||
Comment 9•11 years ago
|
||
Follow-up to fix a UUID mismatch… ಠ_ಠ https://hg.mozilla.org/integration/mozilla-inbound/rev/59360cb3396f
Comment 10•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/ab0974ead030 https://hg.mozilla.org/mozilla-central/rev/59360cb3396f
Status: NEW → RESOLVED
Closed: 11 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla23
Updated•11 years ago
|
Keywords: dev-doc-needed,
site-compat
Comment 11•11 years ago
|
||
This won't affect site compatibility as the availability of the API is limited.
Keywords: dev-doc-needed,
site-compat
You need to log in
before you can comment on or make changes to this bug.
Description
•