856401 - the SCTP library imported in bug 855620 crashes on WinXP in sctp_init_ifns_for_vrf

Status: RESOLVED FIXED

(Core :: WebRTC: Networking, defect)

Description

[Randell Jesup [:jesup] (needinfo me)]

Attachment: Callstack

Appears to be a missing null pointer check (one was removed since the last update we took).

Comment 1

[Randell Jesup [:jesup] (needinfo me)]

Attachment: add back null-check from previous library version

Comment 2

[Randell Jesup [:jesup] (needinfo me)]

Comment on attachment 731617 [details] [diff] [review]
add back null-check from previous library version

Try is at https://tbpl.mozilla.org/?tree=Try&rev=6e6215a166b4
Not certain this is the right solution

Comment 3

[Michael Tüxen]

Attachment: Updated patch (committed upstream)

I think there should be a loop through all addresses like in the IPv6 case.
This also fixes the problem you encountered.
This patch has been committed upstream in
http://code.google.com/p/sctp-refimpl/source/detail?r=8443

Comment 4

[Michael Tüxen]

Comment on attachment 731617 [details] [diff] [review]
add back null-check from previous library version

Even this old code was wrong. It only considers the first address and doesn't loop through all of them like it is done in the IPv6 case.
I updated the patch and committed it upstream. Please review the patch and consider committing them to the mc.
I can't edit the review flags, so please change them appropriately.

Comment 5

[Randell Jesup [:jesup] (needinfo me)]

Comment on attachment 731622 [details] [diff] [review]
Updated patch (committed upstream)

Review of attachment 731622 [details] [diff] [review]:
-----------------------------------------------------------------

r+, though I'll probably just update the library import instead.  I suspect the XP test boxes don't have any adapters visible here, and so my patch which checks for NULL would also be safe (if not correct in a multi-interface machine).  I suspect in the SCTP/DTLS case this is totally moot, though the SCTP library doesn't know that at init time.

Comment 6

[Randell Jesup [:jesup] (needinfo me)]

Try using rev 8443
https://tbpl.mozilla.org/?tree=Try&rev=116497e7f9b1

Comment 7

[Randell Jesup [:jesup] (needinfo me)]

Fixed by checkin for bug 855620