Closed Bug 856426 Opened 11 years ago Closed 10 years ago

fix build warning

Categories

(Core :: Networking, defect)

Product:
Core
Component:
Networking
Platform:
x86_64
Linux
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla29

People

(Reporter: gia, Assigned: gia)

Details

Attachments

(1 file)

patch v1
806 bytes, patch
jesup
: review+
Details | Diff | Splinter Review 
/home/gia/mozilla-central/netwerk/sctp/src/user_environment.c:95:10: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
/home/gia/mozilla-central/netwerk/sctp/src/user_environment.c:95:10: warning: signed and unsigned type in conditional expression [-Wsign-compare]
I will submit the patch soon.
Attached patch patch v1 — — Splinter Review 

        Attachment #731912 -
        Flags: review?

    
    

    
  
Comment on attachment 731912 [details] [diff] [review]
patch v1

I believe the SCTP code belongs to WebRTC (https://wiki.mozilla.org/Modules/Core#WebRTC), so let's have jesup decide what to do here.

        Attachment #731912 -
        Flags: review? → review?(rjesup)

    
  
Assignee: nobody → georgiana.chelu93

        Attachment #731912 -
        Flags: review?(rjesup) → review+

    
    

    
  
Sorry for the delay; just noticed it was waiting
Status: UNCONFIRMED → NEW
Ever confirmed: true

    
  
Keywords: checkin-needed

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/72ec31300662
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla29

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: