856468 - Missing space in last chance of entering PIN

Status: RESOLVED WORKSFORME

(Firefox OS Graveyard :: Gaia::First Time Experience, defect)

Description

[Bartosz Piec]

Attachment: PIN code screenshot

If you enter the PIN code two times wrong you get an information about your last chance. There should be a space put after the sentence: "The PIN was incorrect" and before the following sentence.

See the attachment for the details.

Comment 1

[Aniruddh Chaturvedi]

Attachment: Github Pull Request for this issue

I cannot replicate this bug in the Nightly build, because the Nightly build does not come with support to mock a locked sim card. 
However, I spoke to qDot in the #gaia IRC and he told me that I should be fine with adding the extra space and then sending out a pull request.



[Approval Request Comment] https://github.com/mozilla-b2g/gaia/pull/16100
[Bug caused by] (feature/regressing bug #): 
[User impact] if declined:
[Testing completed]: 
[Risk to taking this patch] (and alternatives if risky):
[String changes made]: Added an extra space

Comment 2

[Stephany Wilkes]

Comment on attachment 8372722 [details] [review]
Github Pull Request for this issue

Flagging Omega for a quick patch review here, which it sounds like :qdot may already have blessed.

Comment 3

[Omega Feng [:Omega] [:馮於懋]]

Comment on attachment 8372722 [details] [review]
Github Pull Request for this issue

This patch is reviewed+

Comment 4

[jackkeeley098]

Attachment: Family Guy

Comment 5

[Sam Foster [:sfoster] (he/him)]

Attachment: ftu-pin-error-last-msg.png

Last change / pin error screen - looks good to me.