Closed Bug 856520 Opened 9 years ago Closed 9 years ago

B2G RIL: RILContentHelper.networkSelectionMode is readonly

Categories

(Core :: DOM: Device Interfaces, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla22
Tracking Status
b2g18 --- affected
b2g18-v1.0.1 --- affected

People

(Reporter: vicamo, Assigned: hsinyi)

References

Details

Attachments

(1 file, 1 obsolete file)

E/GeckoConsole(   45): [JavaScript Error: "setting a property that has only a getter" {file: "jar:file:///system/b2g/omni.ja!/components/RILContentHelper.js" line: 1018}]
120 E/GeckoConsole(  126): [JavaScript Error: "NS_ERROR_ILLEGAL_VALUE: Component returned failure code: 0x80070057 (NS_ERROR_ILLEGAL_VALUE) [nsIXPCComponents_Utils.import]" {file: "resource://gre/modules/service    s-common/utils.js" line: 13}]

This is a follow-up of bug 855643.
(In reply to Vicamo Yang [:vicamo][:vyang] from comment #0)
> E/GeckoConsole(   45): [JavaScript Error: "setting a property that has only
> a getter" {file:
> "jar:file:///system/b2g/omni.ja!/components/RILContentHelper.js" line: 1018}]
> 120 E/GeckoConsole(  126): [JavaScript Error: "NS_ERROR_ILLEGAL_VALUE:
> Component returned failure code: 0x80070057 (NS_ERROR_ILLEGAL_VALUE)
> [nsIXPCComponents_Utils.import]" {file: "resource://gre/modules/service   
> s-common/utils.js" line: 13}]
> 
> This is a follow-up of bug 855643.
Oops... thanks for this catch!
Blocks: 855643
No longer depends on: 855643
Blocks: 852038
No longer blocks: 855643
Depends on: 855643
tef? since it blocks the tef+ bug 852038
blocking-b2g: --- → tef?
Attached patch Patch (obsolete) — Splinter Review
RILContentHelper.networkSelectionMode is a getter, should write to RILContentHelper.rilContext.networkSelectionMode instead.
Attachment #731781 - Flags: review?(allstars.chh)
Comment on attachment 731781 [details] [diff] [review]
Patch

Review of attachment 731781 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/system/gonk/RILContentHelper.js
@@ +475,1 @@
>          && this.rilContext.voiceConnectionInfo.network === network) {

nit, move && to line 474.
Attachment #731781 - Flags: review?(allstars.chh) → review+
blocking-b2g: tef? → tef+
Addressed comment#4. Thanks!
Attachment #731781 - Attachment is obsolete: true
https://hg.mozilla.org/mozilla-central/rev/eca6757e918a
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla22
This issue happens only in m-c, not in b2g-18, so tef-.
blocking-b2g: tef+ → ---
You need to log in before you can comment on or make changes to this bug.