856584 - Regression 845487 - postMessage for workers does not support origin as parameter

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Description

[Cristian Rodriguez (:crdlc)]

This bug depends on bug 845487 - postMessage for workers does not support origin as parameter. Then image synchronization for facebook freinds is broken in all branches

E/GeckoConsole( 5501): [JavaScript Error: "DataCloneError: The object could not be cloned." {file: "app://communications.gaiamobile.org/facebook/js/fb_sync.js" line: 453}]

Comment 1

[Cristian Rodriguez (:crdlc)]

Sorry, it is only reproducible on master, neither v1.1 nor v1.0.1

Comment 2

[Cristian Rodriguez (:crdlc)]

Attachment: Patch v1

Comment 3

[Jose Manuel Cantera]

https://github.com/mozilla-b2g/gaia/commit/4fbf53318c32e27cdbf79ee23955298860ed42e7

Comment 4

[Daniel Coloma:dcoloma]

blocks a blocker

Comment 5

[Cody Roesch [:croesch]]

Can you please provide steps to verify this fix - as we will blackbox test from the UI?

Comment 6

[Cristian Rodriguez (:crdlc)]

1) I import my 23 friends from Facebook (some of them are test friends)
2) I change the profile picture of these test friends
3) After 5 minutes for example, I take my Firefox OS and I go to the import view (click on "uptate friends button"), behind scene, my friends should be updated due to pictures are different
4) I go to contact list and the new pictures should be loaded

Comment 7

[Cody Roesch [:croesch]]

Unagi Build: 20130402070204
Kernel: Dec 5th
Gecko  http://hg.mozilla.org/releases/mozilla-b2g18/rev/68c8a883cfc0
Gaia   1c38c91bb16f2bf0d5066c4787d2249463f61bb3


Unagi Build: 20130402070202
Kernel: Dec 5th
Gecko  http://hg.mozilla.org/releases/mozilla-b2g18_v1_0_1/rev/ccec751a468e
Gaia   ee0bef61c0a25c806dd1eec5a4e047bc418a5f73


Verified in V1 and V1.0.1 that this functionality works. New images appear in the Contacts along with the old ones after a second update as described in comment 6.

Comment 8

[John Ford [:jhford] CET/CEST Berlin Time]

v1-train: da97273e1dc6bbfde20f026834bd0388cde56b91

Comment 9

[John Ford [:jhford] CET/CEST Berlin Time]

v1.0.1: 1173b27f66b9c23ab9b02955230ba7bbdc8e015f