856657 - Go/Search icons in URL bar and keyboard can get out of sync

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Awesomescreen, defect)

Description

[(inactive) Jim Chen [:jchen] [:darchons]]

For example, the URL bar could display Search icon while the keyboard displays Go icon.

Comment 1

[Aaron Train [:aaronmt]]

STR

i) Enter 'mozilla ' (mag glass)
ii) Hit backspace 'mozilla' (mag glass; should be arrow -> keyboard has 'Go')

--
Nightly (04/01), Nexus 4 (Android 4.2.2)

Comment 2

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: Change Go button at the same time as resetting input (v1)

The keyboard's go/search icon changes when we reset the input; we should change the button at that time as well for consistency.

Comment 3

[Chris Peterson [:cpeterson]]

Comment on attachment 735314 [details] [diff] [review]
Change Go button at the same time as resetting input (v1)

Review of attachment 735314 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM!

This fix looks like a good candidate for a UI polish bug that could be uplifted to Aurora. We're still early in this release cycle.

::: mobile/android/base/AwesomeBar.java
@@ +367,2 @@
>          }
>      }

Can we consolidate the duplicated restartInput/setImageResource/setContentDescription code to the end of the method using a "restartInput" (or whatever) local boolean variable?

Comment 4

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: Change Go button at the same time as resetting input (v1.1)

Deduplicated code; carrying over r+




Change Go button at the same time as resetting input (v1)

Comment 5

[(inactive) Jim Chen [:jchen] [:darchons]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/5820dbc75b5a

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/5820dbc75b5a