Closed Bug 856696 Opened 7 years ago Closed 7 years ago

make nsTArray::SwapElements() return void if the array is infalible

Categories

(Core :: XPCOM, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla23

People

(Reporter: tbsaunde, Assigned: tbsaunde)

References

Details

Attachments

(1 file)

No description provided.
Depends on: 856700
Depends on: 856705
Comment on attachment 731937 [details] [diff] [review]
bug 856696 - make nsTArray::SwapElements() return void

r=me, but would you mind indenting this

>-  bool SwapArrayElements(nsTArray_base<Allocator>& other,
>+  typename Alloc::ResultTypeProxy SwapArrayElements(nsTArray_base<Allocator>& > other,
>                            size_type elemSize,
>                            size_t elemAlign);

as something like

>  typename Alloc::ResultTypeProxy
>  SwapArrayElements(nsTArray_base<Allocator>& > other,
>                    size_type elemSize,
>                    size_t elemAlign);

? That seems a lot nicer to me...
Attachment #731937 - Flags: review?(justin.lebar+bug) → review+
https://hg.mozilla.org/mozilla-central/rev/8dca50755ee3
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla23
You need to log in before you can comment on or make changes to this bug.