http://mxr.mozilla.org/mozilla-central/source/mobile/android/base/widget/TopSitesView.java#325 This leads to problems. See bug 856585 comment 0.
No longer blocks: 856621
Component: Awesomescreen → General
Created attachment 732004 [details] [diff] [review] patch This patch moves the cursor execution into the background part of the task. We pass the Map of thumbnails to onPostExecute. I still get thumbnails appearing with this patch, so I guess it didn't break anything. Nothing bad showing up in logcat either.
Attachment #732004 - Flags: review?(lucasr.at.mozilla)
Comment on attachment 732004 [details] [diff] [review] patch Review of attachment 732004 [details] [diff] [review]: ----------------------------------------------------------------- Nice catch. The performance hit is probably coming from the image decoding that was happening on the UI thread i.e. the decodeByteArray() calls.
Attachment #732004 - Flags: review?(lucasr.at.mozilla) → review+
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 23
Comment on attachment 732004 [details] [diff] [review] patch [Approval Request Comment] Bug caused by (feature/regressing bug #): User impact if declined: Executing DB code on the main thread leads to ANR hangs and possible DB locks Testing completed (on m-c, etc.): landed on m-c Risk to taking this patch (and alternatives if risky): some risk, but it's fairly isolated and a straight forward fix String or IDL/UUID changes made by this patch: none I'd like to see this on beta early in the cycle to see if it has any affect on crash stats.
Approving per, https://bugzilla.mozilla.org/show_bug.cgi?id=843005#c10
status-firefox21: --- → affected
status-firefox22: --- → affected
tracking-firefox21: --- → +
tracking-firefox22: --- → +
status-firefox21: affected → fixed
status-firefox22: affected → fixed
status-firefox23: --- → fixed
You need to log in before you can comment on or make changes to this bug.