856728 - TopSitesView.java executes a DB cursor on the main thread

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Mark Finkle (:mfinkle) (use needinfo?)]

http://mxr.mozilla.org/mozilla-central/source/mobile/android/base/widget/TopSitesView.java#325

This leads to problems. See bug 856585 comment 0.

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: patch

This patch moves the cursor execution into the background part of the task. We pass the Map of thumbnails to onPostExecute.

I still get thumbnails appearing with this patch, so I guess it didn't break anything. Nothing bad showing up in logcat either.

Comment 2

[Lucas Rocha (:lucasr)]

Comment on attachment 732004 [details] [diff] [review]
patch

Review of attachment 732004 [details] [diff] [review]:
-----------------------------------------------------------------

Nice catch. The performance hit is probably coming from the image decoding that was happening on the UI thread i.e. the decodeByteArray() calls.

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/72ed3ec3c90b

Comment 4

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/72ed3ec3c90b

Comment 5

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 732004 [details] [diff] [review]
patch

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 
User impact if declined: Executing DB code on the main thread leads to ANR hangs and possible DB locks
Testing completed (on m-c, etc.): landed on m-c
Risk to taking this patch (and alternatives if risky): some risk, but it's fairly isolated and a straight forward fix
String or IDL/UUID changes made by this patch: none

I'd like to see this on beta early in the cycle to see if it has any affect on crash stats.

Comment 6

[bhavana bajaj [:bajaj]]

Approving per, https://bugzilla.mozilla.org/show_bug.cgi?id=843005#c10

Comment 7

[Mark Finkle (:mfinkle) (use needinfo?)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/2f602c0a84aa
https://hg.mozilla.org/releases/mozilla-beta/rev/5085168d92eb