Closed Bug 856749 Opened 7 years ago Closed 7 years ago

[Win] Seam between tab-background-start and tab-background-middle is visible with Australis

Categories

(Firefox :: Theme, defect)

All
Windows 7
defect
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 28

People

(Reporter: fx4waldi, Assigned: MattN)

References

Details

Attachments

(2 files, 2 obsolete files)

Attached image screenshot (obsolete) —
Some australis tabs look bad. See screenshot. I do not know how to reproduce this error, but it appears often.
Attached image screenshot
I also see this.
This is a known issue but there wasn't a bug filed yet so thanks for that.

I believe this only occurs when there is tab overflow (with scroll arrows), is this what you see too?

There is a related issue with OS X on the opposite side which we will leave for a separate bug for now.
Status: UNCONFIRMED → NEW
Ever confirmed: true
Hardware: x86 → All
Summary: Some australis tabs look bad → [Win] Seam between tab-background-start and tab-background-middle is visible with Australis
I also cleaned up the paths by adding spaces around the SVG commands to make the attributes easier to read and diff.  The stroke attributes were apparently not included in the clipPath so we unnecessary.

(Quoting Matthew N. [:MattN] from comment #3)
> I believe this only occurs when there is tab overflow (with scroll arrows),
> is this what you see too?

I remembered wrong, it's actually worse without overflow for me.  I've only seen this on the selected tab and that's all the patch fixes.

> There is a related issue with OS X on the opposite side which we will leave
> for a separate bug for now.

The issue on OS X is with background tabs not the selected one.
Assignee: nobody → mnoorenberghe+bmo
Attachment #731974 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #732642 - Flags: review?(dao)
Comment on attachment 732642 [details] [diff] [review]
v.1 Make start clip-path extend 1px over the middle like end does

>-      <svg:path d="M30,2.005C17.049,2.104,15.508,11.669,14.511,17c-1.565,8.376-4.276,13-13,13L0.34,31H30V2.005z"
>-                stroke-width="1px" />
>+      <svg:path d="M 30,2 C 17.049,2.104,15.508,11.669,14.511,17 c -1.565,8.376,-4.276,13,-13,13 L 0,31 H 31 V 2 z" />

get rid of the space before /> while you're at it...
Attachment #732642 - Flags: review?(dao) → review+
Thanks for the speedy review!
Attachment #732642 - Attachment is obsolete: true
Attachment #732705 - Flags: review+
Whiteboard: [fixed-in-ux]
https://hg.mozilla.org/mozilla-central/rev/b238ff8c6263
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-ux]
Target Milestone: --- → Firefox 28
You need to log in before you can comment on or make changes to this bug.