856840 - Kill FindWrapper

Status: RESOLVED FIXED

(Core :: XPConnect, defect)

Description

[Bobby Holley (:bholley)]

In the absence of GWNOJO, I don't see any reason why this is necessary. But that holder stuff always makes my head hurt.

Comment 1

[Bobby Holley (:bholley)]

https://tbpl.mozilla.org/?tree=Try&rev=3b3b9b46c445

Comment 2

[Bobby Holley (:bholley)]

Attachment: Kill FindWrapper. v1

Green on try.

Comment 3

[Blake Kaplan (:mrbkap) (inactive)]

Comment on attachment 732388 [details] [diff] [review]
Kill FindWrapper. v1

Review of attachment 732388 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/xpconnect/wrappers/XrayWrapper.cpp
@@ +535,1 @@
>      JSObject *holder = GetHolder(wrapper);

Are we guaranteed that wrapper is an Xray wrapper? Is it not possible to stick the wrapper as the prototype of something and end up here as the result of a get through the third object? If that is the case, then it seems like we need to class-check wrapper here.

Comment 4

[Bobby Holley (:bholley)]

Attachment: Kill FindWrapper. v2

Even with some digging, Waldo was unsure as to whether the object parameter
to a JSClass::{get,set}Property hook takes the host object or the receiver
in this case. Let's be safe as Blake suggested.

Comment 5

[Bobby Holley (:bholley)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/42904845f8a2

Comment 6

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/42904845f8a2