856841 - JS implemented ifaces have an unnecessary JSContext* for |any| attributes' getters/setters

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Comment 1

[Reuben Morais [:reuben]]

Ugh, I managed to press some key combination that filed the bug.

For example:

[JSImplementation="@mozilla.org/contactField;1"]
interface ContactField {
  attribute any       type;
};

generates:

JS::Value
ContactField::GetType(JSContext* cx, ErrorResult& aRv) const
{
  return mImpl->GetType(cx, aRv);
}

GetType is:

JS::Value GetType(ErrorResult& aRv, ExceptionHandling aExceptionHandling = eReportExceptions);

Comment 2

[Reuben Morais [:reuben]]

(In reply to Reuben Morais [:reuben] from comment #1)
> GetType is:
> 
> JS::Value GetType(ErrorResult& aRv, ExceptionHandling aExceptionHandling =
> eReportExceptions);

I mean ContactFieldJSImpl::GetType.

Comment 3

[Andrew McCreight [:mccr8]]

My guess is that the any argument creates an "implicit implicit JS Context", which is presumably unnecessary for JS-implemented things.

Comment 4

[Boris Zbarsky [:bzbarsky]]

Attachment: Don't pass in an implicit JSContext based on argument or return value types for JS-implemented interfaces.

Comment 5

[Andrew McCreight [:mccr8]]

Comment on attachment 732162 [details] [diff] [review]
Don't pass in an implicit JSContext based on argument or return value types for JS-implemented interfaces.

Review of attachment 732162 [details] [diff] [review]:
-----------------------------------------------------------------

Nice.

Comment 6

[Boris Zbarsky [:bzbarsky]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/87326badb104

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/87326badb104