Closed
Bug 856879
Opened 11 years ago
Closed 11 years ago
remove constructor arguments from style struct macros
Categories
(Core :: CSS Parsing and Computation, defect)
Core
CSS Parsing and Computation
Tracking
()
RESOLVED
FIXED
mozilla23
People
(Reporter: heycam, Assigned: heycam)
References
Details
Attachments
(1 file)
|
22.94 KB,
patch
|
dbaron
:
review+
|
Details | Diff | Splinter Review |
The third argument in the STYLE_STRUCT{,_RESET,_INHERITED} macros doesn't seem to be used any more. I guess the functionality moved to COMPUTE_START_INHERITED?
Attachment #732137 -
Flags: review?(dbaron)
It was used in nsStyleSet::BuildDefaultStyleData, which went away in https://hg.mozilla.org/mozilla-central/rev/c6e38e325158 . (I probably should have just made all the constructors take a pres context ages ago, though.)
Depends on: 809533
Comment on attachment 732137 [details] [diff] [review] patch >Bug XXXXXX - Remove constructor arguments argument from style struct macros. r? Put the real bug number in, and r=dbaron.
Attachment #732137 -
Flags: review?(dbaron) → review+
|
Assignee | |
Comment 3•11 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/04a6cc892156
|
||
Comment 4•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/04a6cc892156
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla23
You need to log in
before you can comment on or make changes to this bug.
Description
•