Closed Bug 856879 Opened 7 years ago Closed 7 years ago

remove constructor arguments from style struct macros

Categories

(Core :: CSS Parsing and Computation, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla23

People

(Reporter: heycam, Assigned: heycam)

References

Details

Attachments

(1 file)

Attached patch patchSplinter Review
The third argument in the STYLE_STRUCT{,_RESET,_INHERITED} macros doesn't seem to be used any more.  I guess the functionality moved to COMPUTE_START_INHERITED?
Attachment #732137 - Flags: review?(dbaron)
It was used in nsStyleSet::BuildDefaultStyleData, which went away in https://hg.mozilla.org/mozilla-central/rev/c6e38e325158 .

(I probably should have just made all the constructors take a pres context ages ago, though.)
Depends on: 809533
Comment on attachment 732137 [details] [diff] [review]
patch

>Bug XXXXXX - Remove constructor arguments argument from style struct macros. r?

Put the real bug number in, and r=dbaron.
Attachment #732137 - Flags: review?(dbaron) → review+
https://hg.mozilla.org/mozilla-central/rev/04a6cc892156
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla23
You need to log in before you can comment on or make changes to this bug.