856880 - Run jit-tests with --valgrind flag

Status: RESOLVED WONTFIX

(Core :: JavaScript Engine, defect)

Description

[Nicholas Nethercote [inactive]]

If you specify the --valgrind flag to jit-tests.py, a small number (3, IIRC) of them are run under Valgrind, if Valgrind is installed.  It appears I'm the only person who does this regularly.

We should do it on vanilla TBPL runs, because it catches problems like bug 856877.  Because it's only three tests, it hardly slows things down at all, so there shouldn't be a problem with doing it on every run.

Comment 1

[Nicholas Nethercote [inactive]]

BTW, --valgrind-all is the flag that runs all jit-tests under Valgrind.  I'm not suggesting that because it would *much* slower.

Comment 2

[Nicholas Nethercote [inactive]]

js/src/Makefile.in specifies --valgrind in |make check| if MOZ_VALGRIND is defined:

> ifdef MOZ_VALGRIND
> ifndef MOZ_ASAN
> JITTEST_VALGRIND_FLAG = --valgrind
> endif
> endif
>
> check-jit-test::
>         $(wildcard $(RUN_TEST_PROGRAM)) $(PYTHON) -u $(srcdir)/jit-test/jit_test.py \
>                 --no-slow --no-progress --tinderbox --tbpl $(JITTEST_VALGRIND_FLAG) \
>                 $(DIST)/bin/js$(BIN_SUFFIX)

So I guess we need --enable-valgrind in the mozconfig used for the tests.

Comment 3

[(not currently active) Ted Mielczarek]

Dupe of bug 801911?