856921 - Ensure that all quota failures are exposed to JS as QuotaExceededError

Status: RESOLVED FIXED

(Core :: Storage: IndexedDB, defect)

Description

[Ben Turner (not reading bugmail, use the needinfo flag!)]

We found a few places where we turn quota failures into UnknownError instead of QuotaExceededError. This confuses web app authors and we should fix asap.

See attachment 731612 [details] [diff] [review] from bug 856032.

Comment 2

[Jan Varga [:janv]]

Attachment: patch

Comment 3

[Jan Varga [:janv]]

https://tbpl.mozilla.org/?tree=Try&rev=74d79330030b

Comment 4

[Jan Varga [:janv]]

Comment on attachment 8394577 [details] [diff] [review]
patch

Actually, I've decided to silent quota exceeded failures, I'll post a new patch.

Comment 5

[Jan Varga [:janv]]

Attachment: patch v2

Comment 6

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Comment on attachment 8396615 [details] [diff] [review]
patch v2

Review of attachment 8396615 [details] [diff] [review]:
-----------------------------------------------------------------

The duplication of idb error codes in filehandle is unfortunate... Any reason why it needs its own codes?

Comment 7

[Jan Varga [:janv]]

(In reply to ben turner [:bent] (use the needinfo? flag!) from comment #6)
> Comment on attachment 8396615 [details] [diff] [review]
> patch v2
> 
> Review of attachment 8396615 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> The duplication of idb error codes in filehandle is unfortunate... Any
> reason why it needs its own codes?

I've read somewhere that even IDB error codes should merge with existing DOM error codes.
Yeah, I agree it's unfortunate, but I would keep it for now. I don't plan to add any other error codes.

Comment 8

[Jan Varga [:janv]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/47036286feda

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/47036286feda