Closed Bug 856921 Opened 7 years ago Closed 6 years ago

Ensure that all quota failures are exposed to JS as QuotaExceededError

Categories

(Core :: Storage: IndexedDB, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla31

People

(Reporter: bent.mozilla, Assigned: janv)

References

Details

Attachments

(1 file, 1 obsolete file)

We found a few places where we turn quota failures into UnknownError instead of QuotaExceededError. This confuses web app authors and we should fix asap.

See attachment 731612 [details] [diff] [review] from bug 856032.
Duplicate of this bug: 856905
Assignee: nobody → Jan.Varga
Status: NEW → ASSIGNED
Blocks: 964561
Attached patch patch (obsolete) — Splinter Review
Attachment #8394577 - Flags: review?(bent.mozilla)
Comment on attachment 8394577 [details] [diff] [review]
patch

Actually, I've decided to silent quota exceeded failures, I'll post a new patch.
Attachment #8394577 - Flags: review?(bent.mozilla)
Attached patch patch v2Splinter Review
Attachment #8394577 - Attachment is obsolete: true
Attachment #8396615 - Flags: review?(bent.mozilla)
Comment on attachment 8396615 [details] [diff] [review]
patch v2

Review of attachment 8396615 [details] [diff] [review]:
-----------------------------------------------------------------

The duplication of idb error codes in filehandle is unfortunate... Any reason why it needs its own codes?
Attachment #8396615 - Flags: review?(bent.mozilla) → review+
(In reply to ben turner [:bent] (use the needinfo? flag!) from comment #6)
> Comment on attachment 8396615 [details] [diff] [review]
> patch v2
> 
> Review of attachment 8396615 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> The duplication of idb error codes in filehandle is unfortunate... Any
> reason why it needs its own codes?

I've read somewhere that even IDB error codes should merge with existing DOM error codes.
Yeah, I agree it's unfortunate, but I would keep it for now. I don't plan to add any other error codes.
https://hg.mozilla.org/mozilla-central/rev/47036286feda
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla31
You need to log in before you can comment on or make changes to this bug.